Replace yield() and pauseBriefly() with std::this_thread::yield()
Created attachment 219824 [details] Patch
Comment on attachment 219824 [details] Patch Clearing flags on attachment: 219824 Committed r160959: <http://trac.webkit.org/changeset/160959>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 126222
Created attachment 220121 [details] attempt to reland windows build fix has been landed, attempting to reland this patch
Created attachment 220126 [details] wrong patch uploaded before
Comment on attachment 220126 [details] wrong patch uploaded before Clearing flags on attachment: 220126 Committed r161164: <http://trac.webkit.org/changeset/161164>
Hi, I understand the commit but unfortunately it seems to break our cross compilation for ARM This is a silly issue in ARM toolchain (based gcc 4.7.4) since this std::this_thread::yield() is defined under compilation flags which are not set by the compiler A simple but dirty solution was to add those flags into Source/autotools/SetupCompilerFlags.m4 Are you aware about such compilation issue? Do you see a more appropriate location to stuff these flags? Thanks, Pascal Jacquemart
(In reply to comment #9) > Hi, > > I understand the commit but unfortunately it seems to break our cross compilation for ARM > > This is a silly issue in ARM toolchain (based gcc 4.7.4) since this std::this_thread::yield() is defined under compilation flags which are not set by the compiler > > A simple but dirty solution was to add those flags into > Source/autotools/SetupCompilerFlags.m4 > > Are you aware about such compilation issue? > Do you see a more appropriate location to stuff these flags? > I'm not aware of this problem existing on other platforms. Putting the workaround in SetupCompilerFlags.m4 sounds sensible to me.