WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 126148
Support <box> values computed style for 'clip-path' property
https://bugs.webkit.org/show_bug.cgi?id=126148
Summary
Support <box> values computed style for 'clip-path' property
Dirk Schulze
Reported
2013-12-22 23:34:13 PST
Support <box> values computed style for 'clip-path' property
Attachments
Patch
(17.34 KB, patch)
2013-12-25 14:19 PST
,
Dirk Schulze
no flags
Details
Formatted Diff
Diff
Patch
(20.68 KB, patch)
2013-12-25 14:47 PST
,
Dirk Schulze
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
(704.00 KB, application/zip)
2013-12-25 17:20 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
(570.00 KB, application/zip)
2013-12-25 18:53 PST
,
Build Bot
no flags
Details
Patch
(21.09 KB, patch)
2013-12-26 00:08 PST
,
Dirk Schulze
simon.fraser
: review+
simon.fraser
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing
(21.84 KB, patch)
2014-01-02 09:33 PST
,
Dirk Schulze
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Schulze
Comment 1
2013-12-25 14:19:23 PST
Created
attachment 220001
[details]
Patch
WebKit Commit Bot
Comment 2
2013-12-25 14:22:02 PST
Attachment 220001
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt', u'LayoutTests/fast/masking/parsing-clip-path-shape.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/rendering/ClipPathOperation.h', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/rendering/ClipPathOperation.h:46: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/ClipPathOperation.h:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/ClipPathOperation.h:159: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Schulze
Comment 3
2013-12-25 14:47:28 PST
Created
attachment 220003
[details]
Patch Fix styling
WebKit Commit Bot
Comment 4
2013-12-25 14:49:33 PST
Attachment 220003
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt', u'LayoutTests/fast/masking/parsing-clip-path-shape.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/rendering/ClipPathOperation.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/rendering/ClipPathOperation.h:158: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Schulze
Comment 5
2013-12-25 14:57:19 PST
(In reply to
comment #4
)
>
Attachment 220003
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt', u'LayoutTests/fast/masking/parsing-clip-path-shape.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/rendering/ClipPathOperation.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', '--commit-queue']" exit_code: 1 > ERROR: Source/WebCore/rendering/ClipPathOperation.h:158: Place brace on its own line for function definitions. [whitespace/braces] [4] > Total errors found: 1 in 14 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
Ok, that is funny. One message wants me to do one thing, after that I shall revert the change :) I'd land with the brace on its own line.
Build Bot
Comment 6
2013-12-25 17:20:44 PST
Comment on
attachment 220003
[details]
Patch
Attachment 220003
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5731827130040320
New failing tests: css3/masking/clip-path-animation.html
Build Bot
Comment 7
2013-12-25 17:20:48 PST
Created
attachment 220014
[details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 8
2013-12-25 18:53:48 PST
Comment on
attachment 220003
[details]
Patch
Attachment 220003
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5277655813324800
New failing tests: css3/masking/clip-path-animation.html
Build Bot
Comment 9
2013-12-25 18:53:53 PST
Created
attachment 220019
[details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Ryosuke Niwa
Comment 10
2013-12-25 19:51:23 PST
Looks like some test is failing on Mac WK1?
Dirk Schulze
Comment 11
2013-12-25 23:34:59 PST
(In reply to
comment #10
)
> Looks like some test is failing on Mac WK1?
Yes. Will check it locally and upload a new patch if necessary.
Dirk Schulze
Comment 12
2013-12-26 00:08:23 PST
Created
attachment 220028
[details]
Patch Member variable m_referenceBox from ShapeClipPathOperation wasn't initialized correctly.
WebKit Commit Bot
Comment 13
2013-12-26 00:10:03 PST
Attachment 220028
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt', u'LayoutTests/fast/masking/parsing-clip-path-shape.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/rendering/ClipPathOperation.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/rendering/ClipPathOperation.h:160: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 14
2014-01-01 22:44:01 PST
Comment on
attachment 220028
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=220028&action=review
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2869 > + ReferenceClipPathOperation& referenceOperation = *toReferenceClipPathOperation(operation);
I think it would be slightly better to say ReferenceClipPathOperation& referenceOperation = toReferenceClipPathOperation(*operation);
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2875 > + ShapeClipPathOperation& shapeOperation = *toShapeClipPathOperation(operation);
Ditto
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2881 > + BoxClipPathOperation& boxOperation = *toBoxClipPathOperation(operation);
Ditto
> Source/WebCore/rendering/ClipPathOperation.h:148 > + const Path& path(const FloatRect&)
This is confusing. Is it going to return path that just contains the given rect? Should it be called pathForRect()? Why does this change m_path?
Dirk Schulze
Comment 15
2014-01-02 09:33:27 PST
Created
attachment 220230
[details]
Patch for landing
WebKit Commit Bot
Comment 16
2014-01-02 10:08:06 PST
Comment on
attachment 220230
[details]
Patch for landing Clearing flags on attachment: 220230 Committed
r161209
: <
http://trac.webkit.org/changeset/161209
>
WebKit Commit Bot
Comment 17
2014-01-02 10:08:11 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug