Bug 126147 – Support <box> values parsing on 'clip-path' property

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dirk Schulze]

The new syntax of clip-path supports <box> values as specified for background. In addition the keywords 'margin-box' and 'bounding-box' are supported.

[Dirk Schulze]

Created attachment 219894 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 219894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219894&action=review

> Source/WebCore/ChangeLog:13
> +        http://dev.w3.org/fxtf/masking/#the-clip-path

Could you refer to a specific revision of the specification you used to implement
so that we know exactly what the reference point was should the spec change in the future.

> Source/WebCore/css/CSSParser.cpp:5929
> +    if (!shapeFound && value->unit == CSSParserValue::Function) {
> +        RefPtr<CSSBasicShape> shapeValue = parseBasicShape();
> +        if (!shapeValue)
> +            return nullptr;
> +        list->append(cssValuePool().createValue(shapeValue.release()));
> +    } else if (shapeFound && (isBoxValue(valueId) || valueId == CSSValueBoundingBox)) {
> +        list->append(parseValidPrimitive(valueId, value));
> +        m_valueList->next();

It seems strange to repeat this code given shape and box cannot appear twice.
I would refer an approach where we have a loop and guarantee that we run it at most twice,
and making sure that shape & box are parsed at most once.

[Dirk Schulze]

Created attachment 219989 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 219989 [details]
Patch

Rejecting attachment 219989 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 219989, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6429664826359808

[Dirk Schulze]

Created attachment 219990 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 219990 [details]
Patch

Clearing flags on attachment: 219990

Committed r161067: <http://trac.webkit.org/changeset/161067>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.