Bug 125995 – [CSS Shapes] Simplify FloatRoundedRect, BoxShape construction

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hans Muller]

Just a small cleanup suggested by Eric Seidel.  In Shape.cpp::createShape() (creates a BoxShape), replace this:

     FloatRoundedRect bounds(rect, roundedRect.radii().topLeft(), roundedRect.radii().topRight(), roundedRect.radii().bottomLeft(), roundedRect.radii().bottomRight());

with this:

    FloatRoundedRect bounds(rect, roundedRect.radii());

Also: make the change suggested here https://bugs.webkit.org/show_bug.cgi?id=125548#c2.

[Hans Muller]

Created attachment 219676 [details]
Patch.

Cleanup of various internal Shape issues:
- Removed unnecessary Shape() initialization list entries in Shape subclasses per https://bugs.webkit.org/show_bug.cgi?id=125548#c2.
- Used const references instead of pointers for non-deprecated Shape:createShape() logic.
- Replaced createShape() overloads for Rasters and Boxes with functions named createRasterShape() and createBoxShape().
- Added a FloatRoundedRect::Radii() constructor to reduce the parameter list length of the FloatRoundedRect constructor in createBoxShape().

There are no new tests, this is just internal refactoring.

[Andreas Kling]

Comment on attachment 219676 [details]
Patch.

I thought I set r+ on this patch weeks ago :|

[WebKit Commit Bot]

Comment on attachment 219676 [details]
Patch.

Rejecting attachment 219676 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 219676, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5819974354468864

[Hans Muller]

Created attachment 220305 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 220305 [details]
Patch

Clearing flags on attachment: 220305

Committed r161260: <http://trac.webkit.org/changeset/161260>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.