Bug 125548 - [CSS Shapes] Simplify the BoxShape implementation
Summary: [CSS Shapes] Simplify the BoxShape implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-10 15:31 PST by Hans Muller
Modified: 2013-12-18 17:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.79 KB, patch)
2013-12-11 10:20 PST, Hans Muller 		kling: review+
Details | Formatted Diff | Diff
Patch (10.33 KB, patch)
2013-12-18 17:20 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-12-10 15:31:04 PST 
This change is similar to https://bugs.webkit.org/show_bug.cgi?id=125536.

Instead of caching the FloatRoundedRects which represent the BoxShape's shape-padding and shape-margin boundaries, just compute them as needed.
Comment 1 Hans Muller 2013-12-11 10:20:11 PST 
Created attachment 218974 [details]
Patch

Reduce BoxShape's footprint by about 2/3rds. Instead of caching the FloatRoundedRects which represent a BoxShape's shape-padding and shape-margin boundaries, compute them as needed.

No new tests, this is just an internal refactoring.
Comment 2 Andreas Kling 2013-12-18 10:21:15 PST 
Comment on attachment 218974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218974&action=review

r=me

> Source/WebCore/rendering/shapes/BoxShape.h:41
> +        : Shape()

This line can be omitted.
Comment 3 Hans Muller 2013-12-18 17:20:00 PST 
Created attachment 219592 [details]
Patch

Resync.
Comment 4 WebKit Commit Bot 2013-12-18 17:52:33 PST 
Comment on attachment 219592 [details]
Patch

Clearing flags on attachment: 219592

Committed r160814: <http://trac.webkit.org/changeset/160814>
Comment 5 WebKit Commit Bot 2013-12-18 17:52:35 PST 
All reviewed patches have been landed.  Closing bug.