Bug 125536 – [CSS Shapes] Simplify RectangleShape implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hans Muller]

Instead of caching FloatRoundedRect values, just compute them as needed. 

Rename RectangleShape to EllipseShape, to better reflect its use.

[Hans Muller]

To reduce the size of this patch I've left out the BoxShape changes. I also decided not to change the name of the RectangleShape class, since rectangle and inset-rectangle still exist.

[Hans Muller]

Created attachment 218914 [details]
Patch

Instead of caching an instance of a private FloatRoundedRect (ish) class for RectangleShape's shape-margin and shape-padding bounds, we just compute the FloatRect and radii as needed. This reduces the classes footprint a little and it simplifies the implementation.

Removed the private RectangleShape::ShapeBounds class and made its cornerInterceptForWidth() method a static function. Added members for the RectangleShape constructor args, and private getters for their properties. There are no new tests because this is just an internal refactoring.

[WebKit Commit Bot]

Comment on attachment 218914 [details]
Patch

Rejecting attachment 218914 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 218914, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ng file Source/WebCore/rendering/shapes/RectangleShape.cpp
Hunk #7 FAILED at 218.
1 out of 7 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/RectangleShape.cpp.rej
patching file Source/WebCore/rendering/shapes/RectangleShape.h
Hunk #2 succeeded at 58 with fuzz 1.
patching file Source/WebCore/rendering/shapes/Shape.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/48798030

[Hans Muller]

Created attachment 219573 [details]
Patch

Resync.

[WebKit Commit Bot]

Comment on attachment 219573 [details]
Patch

Clearing flags on attachment: 219573

Committed r160802: <http://trac.webkit.org/changeset/160802>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.