RESOLVED FIXED 125915
False webkit-check-style warnings on * 
https://bugs.webkit.org/show_bug.cgi?id=125915
Summary False webkit-check-style warnings on *
Tamas Gergely
Reported 2013-12-18 02:00:37 PST
The webkit-check-style script reports error on multiplication when it checks the usage * in pointer declarations (e.g. in bug 120284).
Attachments
patch (2.36 KB, patch)
2013-12-18 07:00 PST, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tamas Gergely
Comment 1 2013-12-18 02:03:26 PST
A patch for bug 125846 causes this since r160706.
Gergő Balogh
Comment 2 2013-12-18 07:00:43 PST
Created attachment 219533 [details] patch I fix this error. However keep in mind there is impossible (without a full-parser) to distinguish the following to scenarios. pointer declaration: <some type> * <some variable name>; multiplication: <some variable name> * <some (other) variable name>; Of course the latest one is bad practice. So I only filter the case: delete <variable name> * <variable name>; return <variable name> * <variable name>;
WebKit Commit Bot
Comment 3 2013-12-18 10:02:57 PST
Comment on attachment 219533 [details] patch Clearing flags on attachment: 219533 Committed r160772: <http://trac.webkit.org/changeset/160772>
WebKit Commit Bot
Comment 4 2013-12-18 10:02:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.