Bug 125846 - Fix for C++ should have the & or * beside the type not the variable name check.
Summary: Fix for C++ should have the & or * beside the type not the variable name check.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 01:51 PST by Gergő Balogh
Modified: 2013-12-18 02:07 PST (History)
8 users (show)

See Also:

Attachments
patch (2.35 KB, patch)
2013-12-17 02:07 PST, Gergő Balogh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gergő Balogh 2013-12-17 01:51:28 PST 
There is no error message when there is a space between * or & and the variable name.
example:
const char * currentArgument = argv[++argCounter];
Comment 1 Gergő Balogh 2013-12-17 02:07:58 PST 
Created attachment 219404 [details]
patch
Comment 2 WebKit Commit Bot 2013-12-17 08:15:09 PST 
Comment on attachment 219404 [details]
patch

Clearing flags on attachment: 219404

Committed r160706: <http://trac.webkit.org/changeset/160706>
Comment 3 WebKit Commit Bot 2013-12-17 08:15:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2013-12-17 09:19:07 PST 
This needs to be rolled out. It’s complaining on lines of code that are doing multiplication, such as the ones in bug 120284.
Comment 5 Tamas Gergely 2013-12-18 02:07:04 PST 
(In reply to comment #4)
> This needs to be rolled out. It’s complaining on lines of code that are doing multiplication, such as the ones in bug 120284.

I reported bug 125915 against webkit-check-style for this issue.