Bug 125867 - GRAPHICS_SURFACE needed for EGLOffScreenSurface
Summary: GRAPHICS_SURFACE needed for EGLOffScreenSurface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 12:35 PST by Alex Christensen
Modified: 2013-12-17 13:15 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2013-12-17 12:39 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-12-17 12:35:31 PST 
WebGL doesn't work on Windows with accelerated compositing.  GRAPHICS_SURFACE is not necessary except for this compile error, and I'm pretty sure I shouldn't be using it at all.  I'm not sure why, and this does not make it draw to the screen, but this fixes a compile error.  The notImplemented in createOffScreenSurface is not hit.

Also, ENABLE_GLIB_SUPPORT was removed in https://bugs.webkit.org/show_bug.cgi?id=104266 so as long as we're touching WTF, let's clean that up.
Comment 1 Alex Christensen 2013-12-17 12:39:00 PST 
Created attachment 219442 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-17 13:15:22 PST 
Comment on attachment 219442 [details]
Patch

Clearing flags on attachment: 219442

Committed r160725: <http://trac.webkit.org/changeset/160725>
Comment 3 WebKit Commit Bot 2013-12-17 13:15:24 PST 
All reviewed patches have been landed.  Closing bug.