RESOLVED FIXED 104266
Rename ENABLE(GLIB_SUPPORT) to USE(GLIB) 
https://bugs.webkit.org/show_bug.cgi?id=104266
Summary Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
Laszlo Gombos
Reported 2012-12-06 08:01:27 PST
I think this would be more consistent with the existing macro naming conventions. From Platform.h: USE() - use a particular third-party library or optional OS service ENABLE() - turn on a specific feature of WebKit
Attachments
Patch (12.87 KB, patch)
2013-02-08 00:06 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (11.00 KB, patch)
2013-02-08 06:32 PST, Jae Hyun Park 		pnormand: review+
pnormand: commit-queue-
DetailsFormatted DiffDiff
Patch (12.44 KB, patch)
2013-02-10 00:25 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-12-11 00:36:21 PST
I guess this makes sense, any objection Martin?
Martin Robinson
Comment 2 2012-12-11 00:56:44 PST
No objections from me!
Philippe Normand
Comment 3 2012-12-13 06:54:32 PST
Lazlo would you provide a patch?
Laszlo Gombos
Comment 4 2012-12-13 07:22:41 PST
(In reply to comment #3) > Lazlo would you provide a patch? I can provide a patch but I was not planning on it. I wish there would be a more explicit way to mark that the bug author is not actively pursuing fixing the bug (there is of course value in just creating and filing a bug) - but I guess leaving the bug unassigned is the closest we have. Feel free to grab it if you interested.
Jae Hyun Park
Comment 5 2013-02-08 00:06:14 PST
Created attachment 187250 [details] Patch
Laszlo Gombos
Comment 6 2013-02-08 06:14:59 PST
I would prefer not to make changes under WebKit/blackberry as I think those changes are not necessary. As far as I can tell AboutDataUseFeatures.in is not kept up with changes.
Jae Hyun Park
Comment 7 2013-02-08 06:32:51 PST
Created attachment 187307 [details] Patch
Martin Robinson
Comment 8 2013-02-08 07:50:04 PST
Comment on attachment 187307 [details] Patch Looks good to me.
Philippe Normand
Comment 9 2013-02-09 01:57:08 PST
Comment on attachment 187307 [details] Patch Looks good but needs to be rebased before landing!
Jae Hyun Park
Comment 10 2013-02-10 00:25:35 PST
Created attachment 187468 [details] Patch
Jae Hyun Park
Comment 11 2013-02-10 00:27:24 PST
(In reply to comment #9) > (From update of attachment 187307 [details]) > Looks good but needs to be rebased before landing! Thanks for the review! I rebased the patch.
WebKit Review Bot
Comment 12 2013-02-10 03:25:01 PST
Comment on attachment 187468 [details] Patch Clearing flags on attachment: 187468 Committed r142395: <http://trac.webkit.org/changeset/142395>
WebKit Review Bot
Comment 13 2013-02-10 03:25:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.