Bug 125766 – [GTK] [CMake] Add support for building GtkLauncher

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

This is required to do smoke testing for the WebKit1 build.

[Martin Robinson]

Created attachment 219300 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 219300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219300&action=review

> Tools/GtkLauncher/CMakeLists.txt:1
> +add_definitions(-DWEBKIT_EXEC_PATH="${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")

I guess this is OK since we won't install GtkLauncher, right?

> Tools/GtkLauncher/main.c:28
> +#if defined(HAVE_CONFIG_H) && HAVE_CONFIG_H

I take it this is also the case with autotools, right? I think so, but… =)

[Martin Robinson]

Comment on attachment 219300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219300&action=review

>> Tools/GtkLauncher/CMakeLists.txt:1
>> +add_definitions(-DWEBKIT_EXEC_PATH="${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")
> 
> I guess this is OK since we won't install GtkLauncher, right?

Yep. This is duplicated from the autotools build. TBH, I cannot see where it is used, but I guess we could try removing it from both places in a new patch.

>> Tools/GtkLauncher/main.c:28
>> +#if defined(HAVE_CONFIG_H) && HAVE_CONFIG_H
> 
> I take it this is also the case with autotools, right? I think so, but… =)

Hrm...I believe it is. This is cribbed from WTF version. Looks like the build bot did not complain. :)

[Martin Robinson]

Comment on attachment 219300 [details]
Patch

Clearing flags on attachment: 219300

Committed r160805: <http://trac.webkit.org/changeset/160805>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.