Bug 125447 - [EFL][WK2] LayoutTests are broken after r160301
Summary: [EFL][WK2] LayoutTests are broken after r160301
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks: 125438
  Show dependency tree / graph
 
Reported: 2013-12-09 05:44 PST by Ryuan Choi
Modified: 2013-12-09 11:27 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2013-12-09 05:54 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-12-09 05:44:55 PST 
I moved FullScreenManagerProxyClient logic to WebViewEfl, child class of CoordinatedGraphics::WebView) because implementations are EFL specific.
However, CoordinatedGraphics::WebView creates WebPageProxy in constructor and WebPageProxy requires FullScreenManagerProxyClient in constructor.

So, All WK2/Efl based applications got crashed with below message.

pure virtual method called
terminate called without an active exception

I will add virtual methods for Full Screen to CoordinatedGraphics so that WebPageProxy can get FullScreenManagerProxyClient instance without pure viertual methods.
Comment 1 Ryuan Choi 2013-12-09 05:54:18 PST 
Created attachment 218753 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-09 11:27:44 PST 
Comment on attachment 218753 [details]
Patch

Clearing flags on attachment: 218753

Committed r160321: <http://trac.webkit.org/changeset/160321>
Comment 3 WebKit Commit Bot 2013-12-09 11:27:47 PST 
All reviewed patches have been landed.  Closing bug.