Bug 125438 - [EFL][WK2] Move FullScreenManager logic to WebViewEfl
Summary: [EFL][WK2] Move FullScreenManager logic to WebViewEfl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on: 125447
Blocks: 125427
  Show dependency tree / graph
 
Reported: 2013-12-08 22:51 PST by Ryuan Choi
Modified: 2013-12-09 05:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (9.95 KB, patch)
2013-12-08 22:57 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-12-08 22:51:09 PST 
Since r160296, there are build break on EFL port.
Comment 1 Ryuan Choi 2013-12-08 22:57:39 PST 
Created attachment 218727 [details]
Patch
Comment 2 Gyuyoung Kim 2013-12-08 23:38:58 PST 
Comment on attachment 218727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218727&action=review

> Source/WebKit2/UIProcess/efl/WebViewEfl.h:74
> +    virtual void closeFullScreenManager() OVERRIDE { }

Missing FINAL ?
Comment 3 Ryuan Choi 2013-12-08 23:44:09 PST 
Committed r160301: <http://trac.webkit.org/changeset/160301>
Comment 4 Ryuan Choi 2013-12-08 23:45:36 PST 
Comment on attachment 218727 [details]
Patch

cleard flags.
I landed patch after adding FINAL keyword.
Comment 5 Gyuyoung Kim 2013-12-09 03:15:48 PST 
EFL layout test has broken since this commit.

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/11860