Bug 125443 - check-webkit-style: ternary operator in macro call identified as initialization list
Summary: check-webkit-style: ternary operator in macro call identified as initializati...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-09 02:40 PST by Laszlo Vidacs
Modified: 2013-12-09 10:54 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2013-12-09 03:08 PST, Laszlo Vidacs 		no flags Details | Formatted Diff | Diff
Patch (2.18 KB, patch)
2013-12-09 03:44 PST, Laszlo Vidacs 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Vidacs 2013-12-09 02:40:08 PST 
checkstyle issued error for the following patch: https://bugs.webkit.org/show_bug.cgi?id=125298

/WebKitWebSourceGStreamer.cpp:943:
GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length);

ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Comma should be at the beggining of the line in a member initialization list.  [whitespace/init] [4]
Comment 1 Laszlo Vidacs 2013-12-09 03:08:23 PST 
Created attachment 218744 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-12-09 03:24:44 PST 
It would be great if you could add a unit test for this fix.
Comment 3 Laszlo Vidacs 2013-12-09 03:44:45 PST 
Created attachment 218747 [details]
Patch
Comment 4 WebKit Commit Bot 2013-12-09 10:54:53 PST 
Comment on attachment 218747 [details]
Patch

Clearing flags on attachment: 218747

Committed r160318: <http://trac.webkit.org/changeset/160318>
Comment 5 WebKit Commit Bot 2013-12-09 10:54:55 PST 
All reviewed patches have been landed.  Closing bug.