Bug 125298 – 32bit buildfix after r160151

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Laszlo Vidacs]

32bit build fails with the following message:

Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)':
Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:517: error: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Werror=format]

Buildbot: EFL Linux 32-bit Release (Build)

[Laszlo Vidacs]

Created attachment 218503 [details]
Patch

[WebKit Commit Bot]

Attachment 218503 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Comma should be at the beggining of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Laszlo Vidacs]

This seems to be a false positive - no initialization list in this line.

[Philippe Normand]

Comment on attachment 218503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218503&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943
> +    GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length);

Perhaps use %zd ?

[Philippe Normand]

*** This bug has been marked as a duplicate of bug 125296 ***

[Csaba Osztrogonác]

Comment on attachment 218503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218503&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943
>> +    GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length);
> 
> Perhaps use %zd ?

gst_buffer_get_size returns unsigned int (32bit), length is int (32bit).
An unsigned int can be extended properly to long long int (64bit) on x86.
So it is the proper fix, r=me to fix the build as soon as possible.

[Csaba Osztrogonác]

Reopen to let CQ land the fix.

[Csaba Osztrogonác]

*** Bug 125296 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 218503 [details]
Patch

Clearing flags on attachment: 218503

Committed r160196: <http://trac.webkit.org/changeset/160196>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.