Bug 125296 – [EFL] Buildfix after r160151

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit EFL

[Krzysztof Czech]

/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:517: error: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Werror=format]

[Krzysztof Czech]

Created attachment 218496 [details]
patch

[WebKit Commit Bot]

Attachment 218496 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Comma should be at the beggining of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Krzysztof Czech]

Changing format specifier from %ld to %d

[EFL EWS Bot]

Comment on attachment 218496 [details]
patch

Attachment 218496 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/39298350

[EFL EWS Bot]

Comment on attachment 218496 [details]
patch

Attachment 218496 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/43618008

[Nick Diego Yamane (diegoyam)]

/mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)':
/mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format]

Looks like it should be %lu :)

[Ryuan Choi]

(In reply to comment #6)
> /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)':
> /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format]
> 
> Looks like it should be %lu :)

So, is static_cast<unsigned long>(length) only the solution ?

[Krzysztof Czech]

(In reply to comment #7)
> (In reply to comment #6)
> > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)':
> > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format]
> > 
> > Looks like it should be %lu :)
> 
> So, is static_cast<unsigned long>(length) only the solution ?
What about signed values ?, maybe static_cast<long>(length)

[Krzysztof Czech]

Created attachment 218502 [details]
patch

[WebKit Commit Bot]

Attachment 218502 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:  Comma should be at the beggining of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

*** Bug 125298 has been marked as a duplicate of this bug. ***

[Laszlo Vidacs]

A possible solution is submitted to https://bugs.webkit.org/show_bug.cgi?id=125298
Unsigned int does not fit in long int, so the common type for both values could be long long int.

Could you take a look at that patch?

[Csaba Osztrogonác]

Mark this one as duplicate, because the other bug contains the proper fix.

*** This bug has been marked as a duplicate of bug 125298 ***