Bug 125325 - REGRESSION(r160133): broke bindings tests on all the bots (Requested by thorton on #webkit).
Summary: REGRESSION(r160133): broke bindings tests on all the bots (Requested by thort...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
Depends on:
Blocks: 124461
  Show dependency treegraph
Reported: 2013-12-05 17:12 PST by WebKit Commit Bot
Modified: 2013-12-05 17:16 PST (History)
3 users (show)

See Also:

ROLLOUT of r160133 (110.66 KB, patch)
2013-12-05 17:12 PST, WebKit Commit Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-12-05 17:12:04 PST
http://trac.webkit.org/changeset/160133 broke the build:
broke bindings tests on all the bots (Requested by thorton on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2013-12-05 17:12:32 PST
Created attachment 218555 [details]
ROLLOUT of r160133

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Tim Horton 2013-12-05 17:14:11 PST
Darin mentioned yesterday in https://bugs.webkit.org/show_bug.cgi?id=124461 that the patch needed a bindings test rebaseline, but it's nonobvious to me that the changes are intentional, and the reviewer and author both did not perform said rebaseline nor are online. So, cq+.
Comment 3 WebKit Commit Bot 2013-12-05 17:16:50 PST
Comment on attachment 218555 [details]
ROLLOUT of r160133

Clearing flags on attachment: 218555

Committed r160204: <http://trac.webkit.org/changeset/160204>
Comment 4 WebKit Commit Bot 2013-12-05 17:16:52 PST
All reviewed patches have been landed.  Closing bug.