Bug 124461 – Refactor static getter function prototype to include thisValue in addition to the base object

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Refactor static getter function prototype to include thisValue in addition to the base object

[Oliver Hunt]

Created attachment 217133 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 217133 [details]
Patch

Attachment 217133 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/25308009

[Oliver Hunt]

Created attachment 217134 [details]
Patch

[Build Bot]

Comment on attachment 217134 [details]
Patch

Attachment 217134 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/24398004

New failing tests:
compositing/checkerboard.html
compositing/geometry/abs-position-inside-opacity.html
compositing/geometry/fixed-in-composited.html
animations/additive-transform-animations.html
compositing/framesets/composited-frame-alignment.html
animations/3d/state-at-end-event-transform.html
compositing/direct-image-compositing.html
compositing/geometry/layer-due-to-layer-children-deep.html
compositing/iframes/iframe-in-composited-layer.html
compositing/geometry/fixed-position.html
canvas/philip/tests/2d.imageData.object.ctor.html
compositing/animation/state-at-end-event-transform-layer.html
canvas/philip/tests/2d.imageData.create1.type.html
canvas/philip/tests/2d.imageData.get.type.html
animations/3d/change-transform-in-end-event.html
compositing/animation/busy-indicator.html
animations/3d/matrix-transform-type-animation.html
compositing/geometry/horizontal-scroll-composited.html
compositing/iframes/iframe-copy-on-scroll.html
compositing/iframes/iframe-content-flipping.html
compositing/geometry/clipping-foreground.html
compositing/iframes/composited-iframe-scroll.html
animations/animation-css-rule-types.html
compositing/geometry/composited-html-size.html
compositing/compositing-visible-descendant.html
compositing/iframes/composited-iframe-alignment.html
compositing/color-matching/image-color-matching.html
canvas/philip/tests/2d.imageData.create2.type.html
canvas/philip/tests/2d.gradient.object.return.html
compositing/color-matching/pdf-image-match.html

[Build Bot]

Created attachment 217136 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 217134 [details]
Patch

Attachment 217134 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22048036

New failing tests:
compositing/checkerboard.html
canvas/philip/tests/type.prototype.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
compositing/direct-image-compositing.html
canvas/philip/tests/type.extend.html
animations/additive-transform-animations.html
http/tests/appcache/deferred-events-delete-while-raising-timer.html
http/tests/appcache/crash-when-navigating-away-then-back.html
canvas/philip/tests/2d.imageData.object.ctor.html
canvas/philip/tests/2d.imageData.create1.type.html
compositing/animation/state-at-end-event-transform-layer.html
animations/change-keyframes.html
compositing/background-color/background-color-alpha-with-opacity.html
canvas/philip/tests/2d.imageData.get.type.html
animations/3d/change-transform-in-end-event.html
compositing/animation/busy-indicator.html
compositing/backgrounds/fixed-background-on-descendant.html
animations/change-keyframes-name.html
canvas/philip/tests/type.exists.html
animations/cross-fade-border-image-source.html
canvas/philip/tests/2d.pattern.basic.type.html
animations/animation-css-rule-types.html
compositing/compositing-visible-descendant.html
canvas/philip/tests/type.replace.html
compositing/color-matching/image-color-matching.html
canvas/philip/tests/2d.imageData.create2.type.html
http/tests/appcache/404-manifest.html
canvas/philip/tests/2d.gradient.object.return.html
compositing/color-matching/pdf-image-match.html

[Build Bot]

Created attachment 217140 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 217134 [details]
Patch

Attachment 217134 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/25348033

New failing tests:
compositing/checkerboard.html
canvas/philip/tests/type.prototype.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
compositing/direct-image-compositing.html
canvas/philip/tests/type.extend.html
animations/additive-transform-animations.html
http/tests/appcache/deferred-events-delete-while-raising-timer.html
http/tests/appcache/crash-when-navigating-away-then-back.html
canvas/philip/tests/2d.imageData.object.ctor.html
canvas/philip/tests/2d.imageData.create1.type.html
compositing/animation/state-at-end-event-transform-layer.html
animations/change-keyframes.html
compositing/background-color/background-color-alpha-with-opacity.html
canvas/philip/tests/2d.imageData.get.type.html
animations/3d/change-transform-in-end-event.html
compositing/animation/busy-indicator.html
compositing/backgrounds/fixed-background-on-descendant.html
animations/change-keyframes-name.html
canvas/philip/tests/type.exists.html
animations/cross-fade-border-image-source.html
canvas/philip/tests/2d.pattern.basic.type.html
animations/animation-css-rule-types.html
compositing/compositing-visible-descendant.html
canvas/philip/tests/type.replace.html
compositing/color-matching/image-color-matching.html
canvas/philip/tests/2d.imageData.create2.type.html
http/tests/appcache/404-manifest.html
canvas/philip/tests/2d.gradient.object.return.html
compositing/color-matching/pdf-image-match.html

[Build Bot]

Created attachment 217142 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Sam Weinig]

What will the this object be used for? What is this in anticipation for?

[Oliver Hunt]

Created attachment 217464 [details]
Patch

[Build Bot]

Comment on attachment 217464 [details]
Patch

Attachment 217464 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/29938031

New failing tests:
compositing/checkerboard.html
compositing/geometry/abs-position-inside-opacity.html
compositing/geometry/fixed-in-composited.html
compositing/geometry/layer-due-to-layer-children.html
animations/3d/matrix-transform-type-animation.html
compositing/framesets/composited-frame-alignment.html
animations/3d/state-at-end-event-transform.html
compositing/direct-image-compositing.html
compositing/geometry/layer-due-to-layer-children-deep.html
animations/additive-transform-animations.html
compositing/geometry/fixed-position.html
canvas/philip/tests/2d.imageData.object.ctor.html
compositing/animation/state-at-end-event-transform-layer.html
canvas/philip/tests/2d.imageData.create1.type.html
canvas/philip/tests/2d.imageData.get.type.html
animations/3d/change-transform-in-end-event.html
compositing/animation/busy-indicator.html
compositing/geometry/horizontal-scroll-composited.html
compositing/geometry/limit-layer-bounds-overflow-repaint.html
compositing/geometry/clipping-foreground.html
compositing/iframes/composited-iframe-scroll.html
animations/animation-css-rule-types.html
compositing/geometry/composited-html-size.html
compositing/compositing-visible-descendant.html
compositing/iframes/composited-iframe-alignment.html
compositing/color-matching/image-color-matching.html
canvas/philip/tests/2d.imageData.create2.type.html
canvas/philip/tests/2d.gradient.object.return.html
compositing/color-matching/pdf-image-match.html
compositing/geometry/outline-change.html

[Build Bot]

Created attachment 217470 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 217464 [details]
Patch

Attachment 217464 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/30968001

New failing tests:
compositing/checkerboard.html
canvas/philip/tests/type.prototype.html
animations/3d/matrix-transform-type-animation.html
compositing/framesets/composited-frame-alignment.html
animations/3d/state-at-end-event-transform.html
compositing/direct-image-compositing.html
canvas/philip/tests/type.extend.html
animations/additive-transform-animations.html
http/tests/appcache/deferred-events-delete-while-raising-timer.html
http/tests/appcache/crash-when-navigating-away-then-back.html
canvas/philip/tests/2d.imageData.object.ctor.html
canvas/philip/tests/2d.imageData.create1.type.html
compositing/animation/state-at-end-event-transform-layer.html
animations/change-keyframes.html
compositing/background-color/background-color-alpha-with-opacity.html
canvas/philip/tests/2d.imageData.get.type.html
animations/3d/change-transform-in-end-event.html
compositing/animation/busy-indicator.html
compositing/backgrounds/fixed-background-on-descendant.html
animations/change-keyframes-name.html
canvas/philip/tests/type.exists.html
canvas/philip/tests/2d.pattern.basic.type.html
animations/animation-css-rule-types.html
compositing/compositing-visible-descendant.html
canvas/philip/tests/type.replace.html
compositing/color-matching/image-color-matching.html
canvas/philip/tests/2d.imageData.create2.type.html
http/tests/appcache/404-manifest.html
canvas/philip/tests/2d.gradient.object.return.html
compositing/color-matching/pdf-image-match.html

[Build Bot]

Created attachment 217475 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Oliver Hunt]

Created attachment 217477 [details]
Patch

[EFL EWS Bot]

Comment on attachment 217477 [details]
Patch

Attachment 217477 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/30688015

[Oliver Hunt]

Created attachment 217478 [details]
Patch

[EFL EWS Bot]

Comment on attachment 217478 [details]
Patch

Attachment 217478 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/30148027

[EFL EWS Bot]

Comment on attachment 217478 [details]
Patch

Attachment 217478 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/30728018

[kov's GTK+ EWS bot]

Comment on attachment 217478 [details]
Patch

Attachment 217478 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/30698018

[Build Bot]

Comment on attachment 217478 [details]
Patch

Attachment 217478 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/30048068

[Build Bot]

Comment on attachment 217478 [details]
Patch

Attachment 217478 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/30048071

[Build Bot]

Comment on attachment 217478 [details]
Patch

Attachment 217478 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/30718021

[Oliver Hunt]

Created attachment 217487 [details]
Patch

[Oliver Hunt]

Created attachment 217488 [details]
Patch

[Build Bot]

Comment on attachment 217488 [details]
Patch

Attachment 217488 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/31598005

New failing tests:
js/dom/toString-and-valueOf-override.html

[Build Bot]

Created attachment 217496 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 217488 [details]
Patch

Attachment 217488 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/31748023

New failing tests:
js/dom/toString-and-valueOf-override.html

[Build Bot]

Created attachment 217508 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Sam Weinig]

What will the this object be used for? What is this in anticipation for?

[Oliver Hunt]

Created attachment 217618 [details]
Patch

[Build Bot]

Comment on attachment 217618 [details]
Patch

Attachment 217618 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/33388002

New failing tests:
js/dom/toString-and-valueOf-override.html

[Build Bot]

Created attachment 217631 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 217618 [details]
Patch

Attachment 217618 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/33098025

New failing tests:
js/dom/toString-and-valueOf-override.html

[Build Bot]

Created attachment 217639 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Oliver Hunt]

Created attachment 217898 [details]
Patch

[Build Bot]

Comment on attachment 217898 [details]
Patch

Attachment 217898 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/37488029

New failing tests:
js/dom/toString-and-valueOf-override.html

[Build Bot]

Created attachment 217908 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Oliver Hunt]

Created attachment 218451 [details]
Patch

[Geoffrey Garen]

Comment on attachment 218451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218451&action=review

r=me

> Source/JavaScriptCore/ChangeLog:14
> +        that this patch does not result in any change in behaviour

Period, please.

You should also mention the future changes you're planning: moving DOM properties to prototypes.

[Oliver Hunt]

Committed r160133: <http://trac.webkit.org/changeset/160133>

[Darin Adler]

Need to update bindings test expected results.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 125325

[Oliver Hunt]

Committed r160208: <http://trac.webkit.org/changeset/160208>