Bug 125007 – [EFL] Fix incorrectly position of the viewport

• Status: CLOSED
• Resolution: INVALID
• Component: WebKit EFL

[Hunseop Jeong]

This bugs occurred by https://bugs.webkit.org/show_bug.cgi?id=124965.
Added the missed part of previous patch.

[Hunseop Jeong]

Changed the titile name.

[Hunseop Jeong]

(In reply to comment #1)
> Changed the titile name.

titile -> title...

[Hunseop Jeong]

Created attachment 218052 [details]
Patch

[Ryuan Choi]

Comment on attachment 218052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Fix incorrectly position of the viewport

I think that title is really ambiguous.

> Source/WebKit2/ChangeLog:8
> +        The position of viewport is wrong by https://bugs.webkit.org/show_bug.cgi?id=124965.

What is wrong? The previous commit is also to fix wrong viewport issue.

We need more information whether to decide to revert previous one or fix new regression.

[Hunseop Jeong]

(In reply to comment #4)
> (From update of attachment 218052 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [EFL] Fix incorrectly position of the viewport
> 
> I think that title is really ambiguous.
> 
> > Source/WebKit2/ChangeLog:8
> > +        The position of viewport is wrong by https://bugs.webkit.org/show_bug.cgi?id=124965.
> 
> What is wrong? The previous commit is also to fix wrong viewport issue.
> 
> We need more information whether to decide to revert previous one or fix new regression.

It Would be better to revert the previous patch.

[Ryuan Choi]

I reverted r159865 so that this is not needed.

You can upload a patch at Bug 124965 when you find a better solution not to make regression (that the position of events are wrong)

[Gyuyoung Kim]

Comment on attachment 218052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218052&action=review

>>> Source/WebKit2/ChangeLog:3
>>> +        [EFL] Fix incorrectly position of the viewport
>> 
>> I think that title is really ambiguous.
> 
> It Would be better to revert the previous patch.

incorrectly -> incorrect. And also, this patch touch coordinated graphics. So, it would be good to add [CoordinatedGraphics] as well.

> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:248
> +AffineTransform WebView::transformToUserViewport() const

Could you explain why you use *UserViewport* in function name ?

[Gyuyoung Kim]

Comment on attachment 218052 [details]
Patch

Oops. This patch was already closed. Clear r?.

[Hunseop Jeong]

Oops,,! I missed closing the issue. Sorry!