Bug 124958 - Remove BreakingContext's friendship from RenderBlockFlow
Summary: Remove BreakingContext's friendship from RenderBlockFlow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 121261
  Show dependency tree / graph
 
Reported: 2013-11-27 20:42 PST by Zoltan Horvath
Modified: 2013-12-03 23:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2013-11-27 20:45 PST, Zoltan Horvath 		hyatt: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (3.82 KB, patch)
2013-12-03 23:04 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-11-27 20:42:34 PST 
BreakingContext uses only 2 functions from RenderBlockFlow: insertFloatingObject/positionNewFloatOnLine. I added helper functions for LineBreaker, what is already a friend of RenderBlockFlow, so BreakingContext doesn't need to be anymore.
Comment 1 Zoltan Horvath 2013-11-27 20:45:32 PST 
Created attachment 217978 [details]
Patch
Comment 2 Dave Hyatt 2013-12-03 14:21:16 PST 
Comment on attachment 217978 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-12-03 14:33:42 PST 
Comment on attachment 217978 [details]
Patch

Rejecting attachment 217978 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 217978, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderBlockFlow.h
patching file Source/WebCore/rendering/line/BreakingContextInlineHeaders.h
Hunk #1 FAILED at 456.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/line/BreakingContextInlineHeaders.h.rej
patching file Source/WebCore/rendering/line/LineBreaker.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/42958036
Comment 4 Zoltan Horvath 2013-12-03 23:04:17 PST 
Created attachment 218384 [details]
patch for landing
Comment 5 WebKit Commit Bot 2013-12-03 23:53:37 PST 
Comment on attachment 218384 [details]
patch for landing

Clearing flags on attachment: 218384

Committed r160073: <http://trac.webkit.org/changeset/160073>
Comment 6 WebKit Commit Bot 2013-12-03 23:53:39 PST 
All reviewed patches have been landed.  Closing bug.