RESOLVED FIXED 124957
Move space-ignoring inline functions into MidpointState 
https://bugs.webkit.org/show_bug.cgi?id=124957
Summary Move space-ignoring inline functions into MidpointState
Zoltan Horvath
Reported 2013-11-27 20:17:33 PST
Since: - The following inline functions were used only with a mandatory LineMidpointState argument: startIgnoringSpaces, stopIgnoringSpaces, ensureLineBoxInsideIgnoredSpaces, deprecatedAddMidpoint. - TrailingObjects class uses these functions. Since they're inline in BreakingContextInlineHeaders.h, it's hard to separate TrailingObjects into it's own file. (blocks bug #124956) I made these functions as a member of LineMidpointState, and I also updated the call sites.
Attachments
Patch (14.12 KB, patch)
2013-11-27 20:20 PST, Zoltan Horvath 		hyatt: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
patch for landing (14.17 KB, patch)
2013-12-03 23:21 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-11-27 20:20:46 PST
Created attachment 217976 [details] Patch
Dave Hyatt
Comment 2 2013-12-03 14:21:34 PST
Comment on attachment 217976 [details] Patch r=me
WebKit Commit Bot
Comment 3 2013-12-03 14:33:07 PST
Comment on attachment 217976 [details] Patch Rejecting attachment 217976 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 217976, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Core/rendering/line/BreakingContextInlineHeaders.h Hunk #2 succeeded at 127 with fuzz 2. Hunk #4 FAILED at 334. Hunk #7 FAILED at 481. Hunk #8 FAILED at 510. Hunk #9 FAILED at 642. Hunk #10 FAILED at 825. Hunk #12 FAILED at 980. 6 out of 13 hunks FAILED -- saving rejects to file Source/WebCore/rendering/line/BreakingContextInlineHeaders.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/42978025
Zoltan Horvath
Comment 4 2013-12-03 23:21:46 PST
Created attachment 218385 [details] patch for landing
WebKit Commit Bot
Comment 5 2013-12-04 00:26:59 PST
Comment on attachment 218385 [details] patch for landing Clearing flags on attachment: 218385 Committed r160074: <http://trac.webkit.org/changeset/160074>
WebKit Commit Bot
Comment 6 2013-12-04 00:27:02 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2013-12-04 00:59:24 PST
(In reply to comment #5) > (From update of attachment 218385 [details]) > Clearing flags on attachment: 218385 > > Committed r160074: <http://trac.webkit.org/changeset/160074> It broke the debug builds. Could you fix it?
Csaba Osztrogonác
Comment 8 2013-12-04 01:14:41 PST
fix landed in http://trac.webkit.org/changeset/160076
Note You need to log in before you can comment on or make changes to this bug.