Bug 124903 - [CSS Shapes] Support inset parsing
Summary: [CSS Shapes] Support inset parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on: 124905 124906
Blocks: 124173 125112
  Show dependency tree / graph
 
Reported: 2013-11-26 15:41 PST by Zoltan Horvath
Modified: 2013-12-02 15:18 PST (History)
11 users (show)

See Also:

Attachments
patch - style won't make it (55.26 KB, patch)
2013-11-26 17:48 PST, Zoltan Horvath 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch - style won't make it (58.63 KB, patch)
2013-11-26 20:58 PST, Zoltan Horvath 		hyatt: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
updated patch for landing (58.42 KB, patch)
2013-12-02 13:14 PST, Zoltan Horvath 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
updated patch 2 for landing (58.63 KB, patch)
2013-12-02 13:50 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-11-26 15:41:27 PST 
Shapes level 1 defines inset shape, this patch adds support for inset parsing.
Comment 1 Zoltan Horvath 2013-11-26 17:48:07 PST 
Created attachment 217915 [details]
patch - style won't make it
Comment 2 WebKit Commit Bot 2013-11-26 17:50:22 PST 
Attachment 217915 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths.html', u'LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-test-utils.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSBasicShapes.cpp', u'Source/WebCore/css/CSSBasicShapes.h', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSValuePool.h', u'Source/WebCore/platform/LengthSize.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h']" exit_code: 1
Source/WebCore/css/CSSParser.cpp:5444:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-11-26 18:20:19 PST 
Comment on attachment 217915 [details]
patch - style won't make it

Attachment 217915 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/37678003
Comment 4 EFL EWS Bot 2013-11-26 18:34:15 PST 
Comment on attachment 217915 [details]
patch - style won't make it

Attachment 217915 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/37658004
Comment 5 Zoltan Horvath 2013-11-26 20:58:12 PST 
Created attachment 217923 [details]
patch - style won't make it
Comment 6 WebKit Commit Bot 2013-11-26 20:59:06 PST 
Attachment 217923 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-shape-lengths.html', u'LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt', u'LayoutTests/fast/shapes/parsing/parsing-test-utils.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSBasicShapes.cpp', u'Source/WebCore/css/CSSBasicShapes.h', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSValuePool.h', u'Source/WebCore/platform/LengthSize.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h']" exit_code: 1
Source/WebCore/css/CSSParser.cpp:5444:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Dave Hyatt 2013-12-02 09:10:50 PST 
Comment on attachment 217923 [details]
patch - style won't make it

r=me
Comment 8 WebKit Commit Bot 2013-12-02 09:16:23 PST 
Comment on attachment 217923 [details]
patch - style won't make it

Rejecting attachment 217923 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 217923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
et -10 lines).
Hunk #4 succeeded at 368 (offset -10 lines).
patching file Source/WebCore/css/CSSValuePool.h
patching file Source/WebCore/platform/LengthSize.h
patching file Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp
patching file Source/WebCore/rendering/style/BasicShapes.cpp
patching file Source/WebCore/rendering/style/BasicShapes.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/40018077
Comment 9 WebKit Commit Bot 2013-12-02 09:19:30 PST 
Comment on attachment 217923 [details]
patch - style won't make it

Rejecting attachment 217923 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 217923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
et -10 lines).
Hunk #4 succeeded at 368 (offset -10 lines).
patching file Source/WebCore/css/CSSValuePool.h
patching file Source/WebCore/platform/LengthSize.h
patching file Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp
patching file Source/WebCore/rendering/style/BasicShapes.cpp
patching file Source/WebCore/rendering/style/BasicShapes.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/42158016
Comment 10 WebKit Commit Bot 2013-12-02 10:36:29 PST 
Comment on attachment 217923 [details]
patch - style won't make it

Rejecting attachment 217923 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 217923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
et -10 lines).
Hunk #4 succeeded at 368 (offset -10 lines).
patching file Source/WebCore/css/CSSValuePool.h
patching file Source/WebCore/platform/LengthSize.h
patching file Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp
patching file Source/WebCore/rendering/style/BasicShapes.cpp
patching file Source/WebCore/rendering/style/BasicShapes.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/42138037
Comment 11 Zoltan Horvath 2013-12-02 13:14:24 PST 
Created attachment 218208 [details]
updated patch for landing
Comment 12 WebKit Commit Bot 2013-12-02 13:16:28 PST 
Comment on attachment 218208 [details]
updated patch for landing

Rejecting attachment 218208 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 218208, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/WebCore/rendering/shapes/ShapeInsideInfo.cpp
patching file Source/WebCore/rendering/style/BasicShapes.cpp
Hunk #1 succeeded at 299 (offset 45 lines).
patching file Source/WebCore/rendering/style/BasicShapes.h
Hunk #2 FAILED at 52.
Hunk #3 succeeded at 354 (offset 28 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/style/BasicShapes.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/42278004
Comment 13 Zoltan Horvath 2013-12-02 13:50:42 PST 
Created attachment 218211 [details]
updated patch 2 for landing
Comment 14 WebKit Commit Bot 2013-12-02 14:46:11 PST 
Comment on attachment 218211 [details]
updated patch 2 for landing

Clearing flags on attachment: 218211

Committed r159968: <http://trac.webkit.org/changeset/159968>
Comment 15 WebKit Commit Bot 2013-12-02 14:46:15 PST 
All reviewed patches have been landed.  Closing bug.