RESOLVED FIXED 124892
arm and sh4 paths could be merged in ThunkGenerators and privateCompileCTINativeCall 
https://bugs.webkit.org/show_bug.cgi?id=124892
Summary arm and sh4 paths could be merged in ThunkGenerators and privateCompileCTINat...
Julien Brianceau
Reported 2013-11-26 08:41:25 PST
In nativeForGenerator function, CPU(ARM) and CPU(SH4) paths are the same and could be merged to reduce code duplication.
Attachments
Merge arm and sh4 paths in nativeForGenerator function. (4.90 KB, patch)
2013-11-26 08:52 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Merge arm and sh4 paths in nativeForGenerator function (with style fix). (5.30 KB, patch)
2013-11-26 13:53 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. (8.53 KB, patch)
2013-11-27 02:08 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-11-26 08:52:15 PST
Created attachment 217880 [details] Merge arm and sh4 paths in nativeForGenerator function.
WebKit Commit Bot
Comment 2 2013-11-26 08:53:28 PST
Attachment 217880 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerSH4.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp']" exit_code: 1 Source/JavaScriptCore/jit/ThunkGenerators.cpp:356: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Julien Brianceau
Comment 3 2013-11-26 13:53:36 PST
Created attachment 217899 [details] Merge arm and sh4 paths in nativeForGenerator function (with style fix). Same patch with style fix.
Julien Brianceau
Comment 4 2013-11-27 02:08:58 PST
Created attachment 217929 [details] Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
Zoltan Herczeg
Comment 5 2013-11-29 05:47:43 PST
Comment on attachment 217929 [details] Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. r=me
WebKit Commit Bot
Comment 6 2013-11-29 06:13:38 PST
Comment on attachment 217929 [details] Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. Clearing flags on attachment: 217929 Committed r159871: <http://trac.webkit.org/changeset/159871>
WebKit Commit Bot
Comment 7 2013-11-29 06:13:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.