Bug 124867 - More prep work for GStreamer on Windows
Summary: More prep work for GStreamer on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-25 15:14 PST by Alex Christensen
Modified: 2013-12-17 08:52 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2013-11-25 15:21 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2013-12-16 22:14 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-11-25 15:14:58 PST
I have some compile fixes, and g_main_context_iteration needs to be called in the main loop for GStreamer to work.
Comment 1 Alex Christensen 2013-11-25 15:20:39 PST
The WinLauncher change is based on http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=commitdiff;h=895ab852892ec2e6393e41cc8576d4bbcfe636ea
Comment 2 Alex Christensen 2013-11-25 15:21:49 PST
Created attachment 217839 [details]
Patch
Comment 3 Philippe Normand 2013-11-25 23:17:34 PST
Comment on attachment 217839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217839&action=review

> Tools/WinLauncher/WinLauncher.cpp:45
> +#if USE(GSTREAMER)

IIRC there is an ENABLE(GLIB_SUPPORT). Perhaps it would make more sense to enable that macro in WinCairo and use it here.

> Tools/WinLauncher/WinLauncher.cpp:623
> +#if USE(GSTREAMER)

Ditto
Comment 4 Alex Christensen 2013-12-16 22:11:41 PST
https://bugs.webkit.org/show_bug.cgi?id=104266 changed that to USE(GLIB), which would be a better fit there.
Comment 5 Alex Christensen 2013-12-16 22:14:42 PST
Created attachment 219398 [details]
Patch
Comment 6 WebKit Commit Bot 2013-12-17 08:52:27 PST
Comment on attachment 219398 [details]
Patch

Clearing flags on attachment: 219398

Committed r160707: <http://trac.webkit.org/changeset/160707>
Comment 7 WebKit Commit Bot 2013-12-17 08:52:29 PST
All reviewed patches have been landed.  Closing bug.