RESOLVED FIXED 124649
[arm_traditional] Build fails since r159545 
https://bugs.webkit.org/show_bug.cgi?id=124649
Summary [arm_traditional] Build fails since r159545
Julien Brianceau
Reported 2013-11-20 02:48:25 PST
The following implementations are missing in ARM_TRADITIONAL macro assembler since r159545: - void memoryFence() - void load8(const void*, RegisterID) - void load8(const void*, RegisterID)
Attachments
Add missing implementations in ARM_TRADITIONAL macro assembler. (3.26 KB, patch)
2013-11-20 02:54 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-11-20 02:49:21 PST
- void store8(RegisterID, const void*)
Julien Brianceau
Comment 2 2013-11-20 02:54:07 PST
Created attachment 217412 [details] Add missing implementations in ARM_TRADITIONAL macro assembler.
WebKit Commit Bot
Comment 3 2013-11-20 02:55:27 PST
Attachment 217412 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/ARMAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssemblerARM.h']" exit_code: 1 Source/JavaScriptCore/assembler/ARMAssembler.h:233: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2013-11-20 10:30:14 PST
Comment on attachment 217412 [details] Add missing implementations in ARM_TRADITIONAL macro assembler. Clearing flags on attachment: 217412 Committed r159571: <http://trac.webkit.org/changeset/159571>
WebKit Commit Bot
Comment 5 2013-11-20 10:30:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.