Bug 124646 - [armv7][arm64] Build is likely to fail since r159545
Summary: [armv7][arm64] Build is likely to fail since r159545
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108645
  Show dependency tree / graph
 
Reported: 2013-11-20 01:46 PST by Julien Brianceau
Modified: 2013-11-20 08:00 PST (History)
6 users (show)

See Also:

Attachments
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler. (1.57 KB, patch)
2013-11-20 01:50 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler (2). (1.57 KB, patch)
2013-11-20 01:52 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b. (2.15 KB, patch)
2013-11-20 02:37 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-20 01:46:05 PST 
Build is likely to fail since http://trac.webkit.org/changeset/159545 for ARMv7 and ARM64 architectures.

"memfence" should be renamed "memoryFence" in Macro Assembler.
Comment 1 Julien Brianceau 2013-11-20 01:50:53 PST 
Created attachment 217407 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler.
Comment 2 Julien Brianceau 2013-11-20 01:52:21 PST 
Created attachment 217408 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler (2).
Comment 3 Julien Brianceau 2013-11-20 02:37:50 PST 
Created attachment 217411 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b.

I also think that one of the two "OP_DMB_SY_T2a" should be "OP_DMB_SY_T2b".
Comment 4 WebKit Commit Bot 2013-11-20 08:00:21 PST 
Comment on attachment 217411 [details]
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b.

Clearing flags on attachment: 217411

Committed r159564: <http://trac.webkit.org/changeset/159564>
Comment 5 WebKit Commit Bot 2013-11-20 08:00:25 PST 
All reviewed patches have been landed.  Closing bug.