Bug 124623 - PerfTestRunner._generate_results_dict shouldn't depend on test objects
Summary: PerfTestRunner._generate_results_dict shouldn't depend on test objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 124496
Blocks: 124498
  Show dependency tree / graph
 
Reported: 2013-11-19 18:26 PST by Ryosuke Niwa
Modified: 2013-11-21 05:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (9.27 KB, patch)
2013-11-19 18:33 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-11-19 18:26:41 PST 
In order for PerfTest.run to return multiple metrics, PerfTestRunner._generate_results_dict can't depend on test objects
as we can't create multiple test objects per test file.
Comment 1 Ryosuke Niwa 2013-11-19 18:33:52 PST 
Created attachment 217370 [details]
Patch
Comment 2 Ryosuke Niwa 2013-11-21 05:20:24 PST 
Comment on attachment 217370 [details]
Patch

Clearing flags on attachment: 217370

Committed r159617: <http://trac.webkit.org/changeset/159617>
Comment 3 Ryosuke Niwa 2013-11-21 05:20:31 PST 
All reviewed patches have been landed.  Closing bug.