RESOLVED FIXED 124498
Record subtest values in Dromaeo tests 
https://bugs.webkit.org/show_bug.cgi?id=124498
Summary Record subtest values in Dromaeo tests
Ryosuke Niwa
Reported 2013-11-18 05:08:18 PST
Right now, values for subtests inside Dromaeo tests (e.g. dim-attr) are not recorded because run-perf-tests doesn't parse it. Record and submit these subtest values to perf.webkit.org.
Attachments
Patch (28.39 KB, patch)
2013-11-25 04:47 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (474.97 KB, application/zip)
2013-11-25 05:40 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (601.70 KB, application/zip)
2013-11-25 06:27 PST, Build Bot 		no flags
Details
Patch (30.05 KB, patch)
2013-11-25 18:56 PST, Ryosuke Niwa 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-11-25 04:47:15 PST
Created attachment 217792 [details] Patch
WebKit Commit Bot
Comment 2 2013-11-25 04:48:56 PST
Attachment 217792 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'PerformanceTests/ChangeLog', u'PerformanceTests/Dromaeo/resources/dromaeorunner.js', u'PerformanceTests/resources/runner.js', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/performance_tests/perftest.py', u'Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py', u'Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py', u'Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py']" exit_code: 1 Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:116: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2013-11-25 05:40:46 PST
Comment on attachment 217792 [details] Patch Attachment 217792 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/35368461 New failing tests: fast/harness/perftests/runs-per-second-log.html
Build Bot
Comment 4 2013-11-25 05:40:47 PST
Created attachment 217797 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 5 2013-11-25 06:27:11 PST
Comment on attachment 217792 [details] Patch Attachment 217792 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/35368471 New failing tests: fast/harness/perftests/runs-per-second-log.html
Build Bot
Comment 6 2013-11-25 06:27:14 PST
Created attachment 217802 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Ryosuke Niwa
Comment 7 2013-11-25 18:56:17 PST
Created attachment 217857 [details] Patch
Andreas Kling
Comment 8 2013-11-26 20:11:58 PST
Comment on attachment 217857 [details] Patch This is a really sweet feature!
Ryosuke Niwa
Comment 9 2013-11-26 21:30:40 PST
Committed r159805: <http://trac.webkit.org/changeset/159805>
Note You need to log in before you can comment on or make changes to this bug.