Bug 124498 - Record subtest values in Dromaeo tests
Summary: Record subtest values in Dromaeo tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 124623
Blocks: 124497
  Show dependency tree / graph
 
Reported: 2013-11-18 05:08 PST by Ryosuke Niwa
Modified: 2013-11-26 21:30 PST (History)
7 users (show)

See Also:

Attachments
Patch (28.39 KB, patch)
2013-11-25 04:47 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (474.97 KB, application/zip)
2013-11-25 05:40 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (601.70 KB, application/zip)
2013-11-25 06:27 PST, Build Bot 		no flags Details
Patch (30.05 KB, patch)
2013-11-25 18:56 PST, Ryosuke Niwa 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-11-18 05:08:18 PST 
Right now, values for subtests inside Dromaeo tests (e.g. dim-attr) are not recorded
because run-perf-tests doesn't parse it.

Record and submit these subtest values to perf.webkit.org.
Comment 1 Ryosuke Niwa 2013-11-25 04:47:15 PST 
Created attachment 217792 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-25 04:48:56 PST 
Attachment 217792 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'PerformanceTests/ChangeLog', u'PerformanceTests/Dromaeo/resources/dromaeorunner.js', u'PerformanceTests/resources/runner.js', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/performance_tests/perftest.py', u'Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py', u'Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py', u'Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py']" exit_code: 1
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:116:  whitespace before '}'  [pep8/E202] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-11-25 05:40:46 PST 
Comment on attachment 217792 [details]
Patch

Attachment 217792 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/35368461

New failing tests:
fast/harness/perftests/runs-per-second-log.html
Comment 4 Build Bot 2013-11-25 05:40:47 PST 
Created attachment 217797 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2013-11-25 06:27:11 PST 
Comment on attachment 217792 [details]
Patch

Attachment 217792 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/35368471

New failing tests:
fast/harness/perftests/runs-per-second-log.html
Comment 6 Build Bot 2013-11-25 06:27:14 PST 
Created attachment 217802 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Ryosuke Niwa 2013-11-25 18:56:17 PST 
Created attachment 217857 [details]
Patch
Comment 8 Andreas Kling 2013-11-26 20:11:58 PST 
Comment on attachment 217857 [details]
Patch

This is a really sweet feature!
Comment 9 Ryosuke Niwa 2013-11-26 21:30:40 PST 
Committed r159805: <http://trac.webkit.org/changeset/159805>