Bug 124488 - [arm] Build fails since r159395.
Summary: [arm] Build fails since r159395.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108645
  Show dependency tree / graph
 
Reported: 2013-11-18 02:18 PST by Julien Brianceau
Modified: 2013-11-18 03:35 PST (History)
4 users (show)

See Also:

Attachments
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler. (1.46 KB, patch)
2013-11-18 02:19 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-18 02:18:07 PST 
Build fails for CPU(ARM_TRADITIONAL) since http://trac.webkit.org/changeset/159395 because the following function is missing from MacroAssembler:

    Jump branch8(RelationalCondition cond, AbsoluteAddress left, TrustedImm32 right)
Comment 1 Julien Brianceau 2013-11-18 02:19:40 PST 
Created attachment 217183 [details]
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler.
Comment 2 Zoltan Herczeg 2013-11-18 03:10:16 PST 
Comment on attachment 217183 [details]
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler.

Patch looks good.
Comment 3 WebKit Commit Bot 2013-11-18 03:35:03 PST 
Comment on attachment 217183 [details]
Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler.

Clearing flags on attachment: 217183

Committed r159415: <http://trac.webkit.org/changeset/159415>
Comment 4 WebKit Commit Bot 2013-11-18 03:35:05 PST 
All reviewed patches have been landed.  Closing bug.