Bug 124345 – [CSS Grid Layout] Fix positioning of grid items with margins

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Sergio Villar Senin]

There are some FIXME's in the code mentioning that we aren't considering the margins in the layouting of the grid items. Apart from that margins should be also considered when computing the grid's intrinsic size. Fixing this would involve merging these two changes from Blink:

    Positioning should account for the grid items' margins
    
    This change just adds the margin before / start to the grid items'
    positions. In order to get consistent behavior, we now have to call
    findChildLogicalPosition after layout (that's where we compute the
    margins).
    
    Also removed some FIXMEs that were handled in the code.
    
    Review URL: https://chromiumcodereview.appspot.com/23463036

and

    RenderGrid should include grid items' margins in its intrinsic size
    
    To match flexbox and the author's intent, the grid element's intrinsic
    logical widths should account for the fixed margins on any grid items'.
    The change is straightforward and moves the code from RenderFlexibleBox
    to RenderBlock for easy sharing.
    
    Review URL: https://chromiumcodereview.appspot.com/24031007

[Sergio Villar Senin]

Created attachment 216923 [details]
Patch

[EFL EWS Bot]

Comment on attachment 216923 [details]
Patch

Attachment 216923 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/22640307

[Sergio Villar Senin]

(In reply to comment #2)
> (From update of attachment 216923 [details])
> Attachment 216923 [details] did not pass efl-wk2-ews (efl-wk2):
> Output: http://webkit-queues.appspot.com/results/22640307

The patch is ready for review. That failure in the efl EWS affected some other bugs and is not related to the actual patch.

[Sergio Villar Senin]

dhyatt is the refactoring of marginIntrinsicLogicalWidthForChild() compatible with your ongoing RenderBlockFlow work?

[Dave Hyatt]

Comment on attachment 216923 [details]
Patch

r=me

[Sergio Villar Senin]

Committed r159809: <http://trac.webkit.org/changeset/159809>