Bug 123994 - [CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items
Summary: [CSS Grid Layout] Fix the preferred logical widths code to work with spanning...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
: 112388 (view as bug list)
Depends on: 123995 124345
Blocks: 125145
  Show dependency tree / graph
 
Reported: 2013-11-07 07:58 PST by Sergio Villar Senin
Modified: 2013-12-16 04:05 PST (History)
11 users (show)

See Also:

Attachments
Patch (11.30 KB, patch)
2013-11-27 03:09 PST, Sergio Villar Senin 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-11-07 07:58:50 PST 
We should merge:

    Fix the preferred logical widths code to work with spanning grid items

    We implemented a simple algorithm to get the easy cases. The
    algorithm was completely wrong for more complex cases though,
    which was fine as the specification was completely silent on
    how to compute these logical widths. This has been raised to
    the working group in
    http://lists.w3.org/Archives/Public/www-style/2013Oct/0054.html
    No one objected after a week so we should be good to go.
    
    BUG=234197
    
    Review URL: https://codereview.chromium.org/26557002
Comment 1 Sergio Villar Senin 2013-11-27 03:09:08 PST 
Created attachment 217934 [details]
Patch
Comment 2 Sergio Villar Senin 2013-11-28 00:25:13 PST 
*** Bug 112388 has been marked as a duplicate of this bug. ***
Comment 3 Sergio Villar Senin 2013-12-16 04:05:29 PST 
Committed r160633: <http://trac.webkit.org/changeset/160633>