Move out classes from RenderBlockLineLayout.cpp into their own files.
Created attachment 216904 [details] EWS bullet - style won't make it (expected)
Attachment 216904 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 216904 [details] EWS bullet - style won't make it (expected) Attachment 216904 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22700308
Created attachment 216906 [details] EWS bullet2 - style won't make it (expected)
Attachment 216906 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22590168
Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/22889255
Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22838003
Comment on attachment 216906 [details] EWS bullet2 - style won't make it (expected) Attachment 216906 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22720140
Created attachment 216959 [details] EWS bullet3 - style won't make it (expected)
Attachment 216959 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 216959 [details] EWS bullet3 - style won't make it (expected) Attachment 216959 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/23638034
Comment on attachment 216959 [details] EWS bullet3 - style won't make it (expected) Because we now need access to headers in the "rendering/line" directory, we need to update the WebCoreCommon.props file's <AdditionalIncludeDirectories> stanza. Look for "mathml" on that line, and make a similar entry for the new "lines" section. It's possible you will need to update the "WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd" to also copy the header files from "lines", but I think these are not exposed outside of WebCore, so just changing the include path (above) is all that's necessary.
Created attachment 216979 [details] EWS bullet4 - style won't make it (expected)
Attachment 216979 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCoreCommon.props', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 216999 [details] EWS bullet5 for windows - style won't make it (expected)
Attachment 216999 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCoreCommon.props', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/LineInfo.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/line/LineBreaker.cpp', u'Source/WebCore/rendering/line/LineBreaker.h', u'Source/WebCore/rendering/line/LineInfo.cpp', u'Source/WebCore/rendering/line/LineInfo.h', u'Source/WebCore/rendering/line/LineInlineHeaders.h']" exit_code: 1 Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "block" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/line/LineInfo.h:61: The parameter name "lineWidth" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 216999 [details] EWS bullet5 for windows - style won't make it (expected) r=me
Comment on attachment 216999 [details] EWS bullet5 for windows - style won't make it (expected) Clearing flags on attachment: 216999 Committed r159354: <http://trac.webkit.org/changeset/159354>
All reviewed patches have been landed. Closing bug.