Bug 124205 - [CSS Regions] Float get sliced if its container has forced break and is less tall than float
Summary: [CSS Regions] Float get sliced if its container has forced break and is less ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Radu Stavila
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312 124706
  Show dependency tree / graph
 
Reported: 2013-11-12 07:56 PST by Mihai Balan
Modified: 2013-11-21 07:41 PST (History)
2 users (show)

See Also:

Attachments
HTML file highlighting the problem (926 bytes, text/html)
2013-11-12 07:56 PST, Mihai Balan 		no flags Details
Patch containing layout test (3.16 KB, patch)
2013-11-20 09:52 PST, Radu Stavila 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Balan 2013-11-12 07:56:58 PST 
Created attachment 216675 [details]
HTML file highlighting the problem

When a float is taller than its container and overflowing it, setting a forced region break on the container will lead to the float being sliced instead of properly fragmented.

In the attached file, the lines of the float *must not* be sliced, yet they are.

The slicing does not occur if the breaks are unforced (e.g. first region is 30px tall).
Comment 1 Radu Stavila 2013-11-20 09:52:11 PST 
Created attachment 217449 [details]
Patch containing layout test

This problem has been fixed by https://bugs.webkit.org/show_bug.cgi?id=118665. After that patch lands, this new test can be landed as well (the tests fail on the current implementation, without the 118665 patch).
Comment 2 WebKit Commit Bot 2013-11-21 07:41:12 PST 
Comment on attachment 217449 [details]
Patch containing layout test

Clearing flags on attachment: 217449

Committed r159627: <http://trac.webkit.org/changeset/159627>
Comment 3 WebKit Commit Bot 2013-11-21 07:41:13 PST 
All reviewed patches have been landed.  Closing bug.