There should be some unused parametes, that cause build warning during EFL / EFL --minimal build in WebKit2.
Created attachment 216661 [details] Patch There were some unused parameters, that cause build warning during EFL / EFL --minimal build in WebKit2, this patch will fix most of them.
In Bug 124202, you only touch EFL WK1. That's why I said to add [EFL] prefix in title. However, this bug isn't only for EFL port. So, you have not to add [EFL] prefix.
Created attachment 216664 [details] Patch v2 Fixed the title in the patch.
Created attachment 216666 [details] Patch v3 Restored the original title
Created attachment 216680 [details] Patch v4 Updated the patch to be up to date.
Created attachment 216690 [details] Patch v5 reUpdated the patch to be up to date.
LGTM, but it needs WK2 owner review. WK2 owners?
Comment on attachment 216690 [details] Patch v5 Rejecting attachment 216690 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 216690, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: _by_email return self._reviewer_only(self.contributor_by_email(email)) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/config/committers.py", line 264, in contributor_by_email return self._email_to_account_map().get(email.lower()) if email else None File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/config/committers.py", line 164, in _email_to_account_map assert(email not in self._accounts_by_email) # We should never have duplicate emails. AssertionError Full output: http://webkit-queues.appspot.com/results/23688024
Comment on attachment 216690 [details] Patch v5 Clearing flags on attachment: 216690 Committed r159333: <http://trac.webkit.org/changeset/159333>
All reviewed patches have been landed. Closing bug.