Bug 124202 - [EFL] Cleanup the build from unused parameters in WebKit
Summary: [EFL] Cleanup the build from unused parameters in WebKit
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-12 06:07 PST by Tibor Mészáros
Modified: 2013-11-12 17:35 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.75 KB, patch)
2013-11-12 06:19 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Patch v2 (2.76 KB, patch)
2013-11-12 06:30 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Patch v3 (2.76 KB, patch)
2013-11-12 09:04 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2013-11-12 06:07:25 PST 
There should be some unused parametes, that cause build warning during EFL / EFL --minimal build in WebKit.
Comment 1 Tibor Mészáros 2013-11-12 06:19:39 PST 
Created attachment 216660 [details]
Patch

There were some unused parameters, that cause build warning during EFL / EFL --minimal build in WebKit, this patch will fix most of them.
Comment 2 Gyuyoung Kim 2013-11-12 06:23:19 PST 
Comment on attachment 216660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216660&action=review

Need to do rebase.

> Source/WebKit/efl/ChangeLog:3
> +        Cleanup the build from unused parameters in WebKit

Please add [EFL] prefix to title.
Comment 3 Tibor Mészáros 2013-11-12 06:30:51 PST 
Created attachment 216663 [details]
Patch v2

Fixed the title in the patch.
Comment 4 Gyuyoung Kim 2013-11-12 06:44:45 PST 
Comment on attachment 216663 [details]
Patch v2

It looks patch is still out of date.
Comment 5 Tibor Mészáros 2013-11-12 09:04:00 PST 
Created attachment 216682 [details]
Patch v3

Updated the patch to be up to date.
Comment 6 Tibor Mészáros 2013-11-12 09:55:11 PST 
Comment on attachment 216682 [details]
Patch v3

this patch is outdated. It is already fixed in the past.
Comment 7 Tibor Mészáros 2013-11-12 09:58:09 PST 
This bug is outdated, it was resolved in the past
Comment 8 Gyuyoung Kim 2013-11-12 17:35:37 PST 
I think this is close to "RESOLVED INVALID" or "RESOLVED WORKSFORME".