Bug 12412 - "unimplemented propertyID: 46" seen at dojotoolkit.org
Summary: "unimplemented propertyID: 46" seen at dojotoolkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL: http://dojotoolkit.org/
Keywords:
Depends on:
Blocks: 13846
  Show dependency treegraph
 
Reported: 2007-01-26 03:12 PST by Darin Adler
Modified: 2007-05-23 10:35 PDT (History)
1 user (show)

See Also:


Attachments
patch, including layout test updates (49.38 KB, patch)
2007-01-26 03:36 PST, Darin Adler
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-01-26 03:12:47 PST
As seen in bug 11673, this error message appears when trying to browse at dojotoolkit.org
Comment 1 Darin Adler 2007-01-26 03:36:33 PST
Created attachment 12678 [details]
patch, including layout test updates
Comment 2 mitz 2007-01-26 04:20:17 PST
Comment on attachment 12678 [details]
patch, including layout test updates

I think that as an enum type, property IDs should not use "all caps with underscores" style. It doesn't have to be part of this patch, but do you think it could change in the future? (I'm not sure what the -webkit- values would look like).
Comment 3 Darin Adler 2007-01-26 10:51:13 PST
(In reply to comment #2)
> I think that as an enum type, property IDs should not use "all caps with
> underscores" style. It doesn't have to be part of this patch, but do you think
> it could change in the future? (I'm not sure what the -webkit- values would
> look like).

Yes, I had the same thought. I'd love to rename these at some point in the future. Making them identifiers instead of macros clears the way to using a style other than the SHOUTING_WORDS style.
Comment 4 Beth Dakin 2007-01-26 10:59:39 PST
Comment on attachment 12678 [details]
patch, including layout test updates

Looks good!
Comment 5 Sam Weinig 2007-01-26 18:32:45 PST
Landed in r19175.