Bug 123849 - FTL should support NewObject
Summary: FTL should support NewObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2013-11-05 19:12 PST by Filip Pizlo
Modified: 2013-11-05 20:38 PST (History)
9 users (show)

See Also:

Attachments
the patch (6.88 KB, patch)
2013-11-05 19:13 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-11-05 19:12:41 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-11-05 19:13:36 PST 
Created attachment 216109 [details]
the patch
Comment 2 WebKit Commit Bot 2013-11-05 19:15:56 PST 
Attachment 216109 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp', u'Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp']" exit_code: 1
Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:94:  JSCell_freeListNext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2013-11-05 20:38:25 PST 
Landed in http://trac.webkit.org/changeset/158717