Bug 123682 - LLVM assertion failures should funnel into WTF's crash handling
Summary: LLVM assertion failures should funnel into WTF's crash handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2013-11-02 12:19 PDT by Filip Pizlo
Modified: 2013-11-04 20:34 PST (History)
12 users (show)

See Also:

Attachments
the patch (12.65 KB, patch)
2013-11-02 12:25 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-11-02 12:19:23 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-11-02 12:25:06 PDT 
Created attachment 215826 [details]
the patch
Comment 2 WebKit Commit Bot 2013-11-02 12:27:22 PDT 
Attachment 215826 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/llvm/InitializeLLVM.cpp', u'Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp', u'Source/JavaScriptCore/llvm/library/LLVMExports.cpp', u'Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp', u'Source/JavaScriptCore/llvm/library/LLVMTrapCallback.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Assertions.h', u'Tools/ChangeLog', u'Tools/Scripts/configure-llvm']" exit_code: 1
Source/WTF/wtf/Assertions.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2013-11-02 14:08:51 PDT 
Comment on attachment 215826 [details]
the patch

r=me
Comment 4 Filip Pizlo 2013-11-02 18:33:16 PDT 
Landed in http://trac.webkit.org/changeset/158509