Bug 123585 - run-javascriptcore-tests is failing on Windows
Summary: run-javascriptcore-tests is failing on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 121972
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-31 13:02 PDT by Ryosuke Niwa
Modified: 2013-12-03 11:55 PST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Brent Fulgham 2013-11-18 10:25:52 PST 
Are any of the JSC guys looking at these failures?
Comment 2 Geoffrey Garen 2013-11-18 11:05:58 PST 
The first step here is to build locally and get the output from the failing run. The buildbot doesn't seem to have it.
Comment 3 Brent Fulgham 2013-11-22 16:01:53 PST 
It looks like the issue is that testapi.exe fails immediately, stopping the tests from running at all.

If I run "run-javascriptcore-tests --debug --no-build --no-testapi" I get a clean run:

Results for Mozilla tests:
    0 regressions found.
    0 tests fixed.
    OK.
Comment 4 Filip Pizlo 2013-11-22 16:08:13 PST 
(In reply to comment #3)
> It looks like the issue is that testapi.exe fails immediately, stopping the tests from running at all.
> 
> If I run "run-javascriptcore-tests --debug --no-build --no-testapi" I get a clean run:
> 
> Results for Mozilla tests:
>     0 regressions found.
>     0 tests fixed.
>     OK.

OK, though it would be great to port the jsc-stress-tests to Windows also.  The Mozilla tests don't really exercise the system.  jsc-stress-tests do, and they might be able to tell you more about why testapi is failing.  They'll probably reveal other bugs that aren't currently covered by layout tests, mozilla tests, or anything else.

Porting run-jsc-stress-tests just involves some Windows script foo.
Comment 5 Brent Fulgham 2013-11-22 16:25:35 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > It looks like the issue is that testapi.exe fails immediately, stopping the tests from running at all.
> > 
> > If I run "run-javascriptcore-tests --debug --no-build --no-testapi" I get a clean run:
> > 
> > Results for Mozilla tests:
> >     0 regressions found.
> >     0 tests fixed.
> >     OK.
> 
> OK, though it would be great to port the jsc-stress-tests to Windows also.  The Mozilla tests don't really exercise the system.  jsc-stress-tests do, and they might be able to tell you more about why testapi is failing.  They'll probably reveal other bugs that aren't currently covered by layout tests, mozilla tests, or anything else.
> 
> Porting run-jsc-stress-tests just involves some Windows script foo.

I'll see about getting the stress tests running under https://bugs.webkit.org/show_bug.cgi?id=124801.
Comment 6 Brent Fulgham 2013-12-03 11:55:15 PST 
These are now working properly.  Closing.