RESOLVED FIXED 123473
Explicitly initialize base class in MediStreamTrackPrivate copy constructor 
https://bugs.webkit.org/show_bug.cgi?id=123473
Summary Explicitly initialize base class in MediStreamTrackPrivate copy constructor
Thiago de Barros Lacerda
Reported 2013-10-29 14:41:30 PDT
Ports that enable Wextra and Werror must do that to compile.
Attachments
Patch (1.56 KB, patch)
2013-10-29 14:43 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.53 KB, patch)
2013-10-29 15:01 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.54 KB, patch)
2013-10-30 11:09 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-10-29 14:43:21 PDT
Created attachment 215429 [details] Patch
Darin Adler
Comment 2 2013-10-29 14:50:42 PDT
Comment on attachment 215429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215429&action=review > Source/WebCore/ChangeLog:10 > + Ports that enable Wextra and Werror must do that to compile. Why? This is very surprising. Are you sure this is not a compiler bug? > Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:46 > + : RefCounted<MediaStreamTrackPrivate>() I think you can also just do: : RefCounted() But do we really need this? I’m extremely surprised. We definitely use -Wextra and -Werror in the Mac port.
Thiago de Barros Lacerda
Comment 3 2013-10-29 14:54:53 PDT
(In reply to comment #2) > (From update of attachment 215429 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215429&action=review > > > Source/WebCore/ChangeLog:10 > > + Ports that enable Wextra and Werror must do that to compile. > > Why? This is very surprising. Are you sure this is not a compiler bug? > > > Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:46 > > + : RefCounted<MediaStreamTrackPrivate>() > > I think you can also just do: > > : RefCounted() > > But do we really need this? I’m extremely surprised. > > We definitely use -Wextra and -Werror in the Mac port. Sorry, the correct flag is -Werror=extra, I'm using gcc 4.8.2
Thiago de Barros Lacerda
Comment 4 2013-10-29 15:01:46 PDT
Created attachment 215434 [details] Patch for landing
Philippe Normand
Comment 5 2013-10-30 09:37:42 PDT
The patch for landing should have Reviewed by filled, and no need to set review flag.
Thiago de Barros Lacerda
Comment 6 2013-10-30 11:01:20 PDT
(In reply to comment #5) > The patch for landing should have Reviewed by filled, and no need to set review flag. Sorry, I forgot that
Thiago de Barros Lacerda
Comment 7 2013-10-30 11:09:50 PDT
Created attachment 215531 [details] Patch for landing
WebKit Commit Bot
Comment 8 2013-10-30 11:54:43 PDT
Comment on attachment 215531 [details] Patch for landing Clearing flags on attachment: 215531 Committed r158296: <http://trac.webkit.org/changeset/158296>
Brent Fulgham
Comment 9 2013-10-31 14:02:20 PDT
Comment on attachment 215429 [details] Patch Clearing flag to remove from review queue.
Brent Fulgham
Comment 10 2013-10-31 14:02:58 PDT
Comment on attachment 215434 [details] Patch for landing Clearing flags to remove from review queue.
Brent Fulgham
Comment 11 2013-10-31 14:03:17 PDT
All reviewed patches are landed.
Note You need to log in before you can comment on or make changes to this bug.