Bug 123422 – Remote Layer Tree: Support tiled drawing and use it for the main frame

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

And then we'll finally have page contents painting!

[Tim Horton]

Created attachment 215413 [details]
patch

[Tim Horton]

Comment on attachment 215413 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215413&action=review

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:153
> +    // This is unfortunate. I really want a nice way at the PlatformCALayer level to override things but fall back on the -Remote or -Mac or -Win specific behavior (so we can get rid of our CALayer subclasses and make painting more straightforward).

I will get rid of this comment, didn't mean to include it (and basically moved it into the ChangeLog anyway).

[WebKit Commit Bot]

Attachment 215413 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h']" exit_code: 1
Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:41:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 215416 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 215416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215416&action=review

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:52
> +
> +

Extra line.

[Tim Horton]

http://trac.webkit.org/changeset/158223

[Tim Horton]

and follow up in http://trac.webkit.org/changeset/158224