Bug 123418 - Make TileController create the appropriate PlatformCALayer subclasses
Summary: Make TileController create the appropriate PlatformCALayer subclasses
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Depends on:
Blocks: 123422
  Show dependency treegraph
Reported: 2013-10-28 13:55 PDT by Tim Horton
Modified: 2013-10-28 19:44 PDT (History)
6 users (show)

See Also:

patch (12.04 KB, patch)
2013-10-28 14:07 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
patch (9.40 KB, patch)
2013-10-28 17:59 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-28 13:55:11 PDT
Right now it always makes PlatformCALayerMac, but it should instead ask its owning GraphicsLayer to make an appropriate PlatformCALayer, be it Mac, Win, or Remote.
Comment 1 Tim Horton 2013-10-28 14:07:21 PDT
Created attachment 215332 [details]

Not sure if I should move LayerType enum to a different file to get rid of this nasty casting, or if there's a better solution.
Comment 2 Tim Horton 2013-10-28 17:59:08 PDT
Created attachment 215355 [details]
Comment 3 Simon Fraser (smfr) 2013-10-28 18:24:04 PDT
Comment on attachment 215355 [details]

Let's call it "compatible".
Comment 4 Tim Horton 2013-10-28 19:44:00 PDT