Bug 123330 - Fix the ENABLE(CSS_FILTERS) && USE(COORDINATED_GRAPHICS) build after r157803
Summary: Fix the ENABLE(CSS_FILTERS) && USE(COORDINATED_GRAPHICS) build after r157803
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Blocks: 123139
  Show dependency treegraph
Reported: 2013-10-25 02:49 PDT by Csaba Osztrogonác
Modified: 2013-10-25 23:35 PDT (History)
5 users (show)

See Also:

Patch (2.31 KB, patch)
2013-10-25 03:08 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-10-25 02:49:02 PDT
SSIA. Patch is coming.
Comment 1 Csaba Osztrogonác 2013-10-25 03:08:45 PDT
Created attachment 215158 [details]

Coordinated Graphics already has its own implementation for encoding/decoding FilterOperations in Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp and it works with FilterOperation::VALIDATED_CUSTOM typed filter operations too. r157803 caused build failure on USE(COORDINATED_GRAPHICS) platforms if ENABLE(CSS_FILTERS) is true due to duplicated encoder/decoder implementation.
Comment 2 Csaba Osztrogonác 2013-10-25 03:14:38 PDT
An ideal fix would be to merge the two code paths ... but I don't know if
Apple wants FilterOperation::VALIDATED_CUSTOM or Coordinated Graphics platforms
could live without it. So the proposed fix is the most conservative way for
the fix without any behavioural change on any platform.
Comment 3 WebKit Commit Bot 2013-10-25 23:35:40 PDT
Comment on attachment 215158 [details]

Clearing flags on attachment: 215158

Committed r158081: <http://trac.webkit.org/changeset/158081>
Comment 4 WebKit Commit Bot 2013-10-25 23:35:41 PDT
All reviewed patches have been landed.  Closing bug.