Bug 123139 – Remote Layer Tree: Support hardware accelerated filters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

I took the approach of serializing FilterOperation and FilterOperations and using existing PlatformCAFiltersMac code to apply them on the UI process side.

I haven't added custom filter support yet, that might be slightly more tricky.

[Tim Horton]

Created attachment 214823 [details]
patch

[Tim Horton]

(In reply to comment #0)
> I took the approach of serializing FilterOperation and FilterOperations and using existing PlatformCAFiltersMac code to apply them on the UI process side.
> 
> I haven't added custom filter support yet, that might be slightly more tricky.

Actually it looks like we don't have accelerated custom filters so we don't need this.

[EFL EWS Bot]

Comment on attachment 214823 [details]
patch

Attachment 214823 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/8848227

[Anders Carlsson]

Comment on attachment 214823 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214823&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1183
> +static void encodeFilterOperation(ArgumentEncoder& encoder, FilterOperation* filter)

I think FilterOperation should be a const reference.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1318
> +        filters.operations().append(filter);

Can use std::move(filter) here to avoid ref churn.

[Tim Horton]

http://trac.webkit.org/changeset/157803