RESOLVED FIXED 123302
Get rid of InlineStart so that I don't have to implement it in FTL
https://bugs.webkit.org/show_bug.cgi?id=123302
Summary Get rid of InlineStart so that I don't have to implement it in FTL
Filip Pizlo
Reported 2013-10-24 17:14:43 PDT
I was going to implement it in the FTL but then I realized that the node is thoroughly pointless.
Attachments
work in progress (15.84 KB, patch)
2013-10-24 17:17 PDT, Filip Pizlo
no flags
almost done (15.99 KB, patch)
2013-10-24 17:48 PDT, Filip Pizlo
no flags
the patch (18.69 KB, patch)
2013-10-24 18:08 PDT, Filip Pizlo
ggaren: review+
Filip Pizlo
Comment 1 2013-10-24 17:17:12 PDT
Created attachment 215123 [details] work in progress
Filip Pizlo
Comment 2 2013-10-24 17:48:49 PDT
Created attachment 215126 [details] almost done This patch is basically ready except that it reveals some bugs in the FTL by virtue of increasing FTL coverage.
Filip Pizlo
Comment 3 2013-10-24 18:08:29 PDT
Created attachment 215127 [details] the patch
Geoffrey Garen
Comment 4 2013-10-24 20:38:38 PDT
Comment on attachment 215127 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=215127&action=review r=me > Source/JavaScriptCore/ftl/FTLLink.cpp:61 > + state.jitCode->common.inlineCallFrames = state.graph.m_inlineCallFrames.release(); I believe std::move() (rather than release()) is the preferred way to do this these days.
Filip Pizlo
Comment 5 2013-10-28 11:02:58 PDT
Note You need to log in before you can comment on or make changes to this bug.