Bug 123302 - Get rid of InlineStart so that I don't have to implement it in FTL
Summary: Get rid of InlineStart so that I don't have to implement it in FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2013-10-24 17:14 PDT by Filip Pizlo
Modified: 2013-10-28 11:02 PDT (History)
7 users (show)

See Also:

Attachments
work in progress (15.84 KB, patch)
2013-10-24 17:17 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
almost done (15.99 KB, patch)
2013-10-24 17:48 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (18.69 KB, patch)
2013-10-24 18:08 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-24 17:14:43 PDT 
I was going to implement it in the FTL but then I realized that the node is thoroughly pointless.
Comment 1 Filip Pizlo 2013-10-24 17:17:12 PDT 
Created attachment 215123 [details]
work in progress
Comment 2 Filip Pizlo 2013-10-24 17:48:49 PDT 
Created attachment 215126 [details]
almost done

This patch is basically ready except that it reveals some bugs in the FTL by virtue of increasing FTL coverage.
Comment 3 Filip Pizlo 2013-10-24 18:08:29 PDT 
Created attachment 215127 [details]
the patch
Comment 4 Geoffrey Garen 2013-10-24 20:38:38 PDT 
Comment on attachment 215127 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215127&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLink.cpp:61
> +        state.jitCode->common.inlineCallFrames = state.graph.m_inlineCallFrames.release();

I believe std::move() (rather than release()) is the preferred way to do this these days.
Comment 5 Filip Pizlo 2013-10-28 11:02:58 PDT 
Landed in http://trac.webkit.org/changeset/158116