Bug 123247 – [ARM]Fix CPU(ARM_TRADITIONAL) build after r157690.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[ChangSeok Oh]

Build break with ARM compiler.

../../Source/JavaScriptCore/assembler/ARMAssembler.cpp: In member function 'WTF::PassRefPtr<WTF::MetaAllocatorHandle> JSC::ARMAssembler::executableCopy(JSC::VM&, void*, JSC::JITCompilationEffort)':
../../Source/JavaScriptCore/assembler/ARMAssembler.cpp:401:54: error: 'JSC::ARMAssembler::ARMBuffer' has no member named 'executableCopy'

[Csaba Osztrogonác]

Created attachment 215034 [details]
Patch

After r157690 JSC::ARMAssembler::executableCopy became unreachable function and now causes build failure due to calling the non-existent JSC::ARMAssembler::ARMBuffer in it.

[Csaba Osztrogonác]

Comment on attachment 215034 [details]
Patch

It isn't the proper fix. (after discussing with Julien Brianceau)

[Julien Brianceau]

I think it will take a little time to have a proper fix, so if you want to fix the build, perhaps you could just #if 0 the code instead of removing it ?
It will help to reuse the code in the future "proper" patch.

[Julien Brianceau]

Created attachment 215340 [details]
Fix CPU(ARM_TRADITIONAL) build after r157690.

[Julien Brianceau]

Created attachment 215371 [details]
(better) Fix CPU(ARM_TRADITIONAL) build after r157690

Same patch without a useless parameter "from" for prepareExecutableCopy

[Michael Saboff]

Comment on attachment 215371 [details]
(better) Fix CPU(ARM_TRADITIONAL) build after r157690

View in context: https://bugs.webkit.org/attachment.cgi?id=215371&action=review

r=me with addition of ChangeLog comments.

> Source/JavaScriptCore/ChangeLog:7
> +

Add a comment as to what you did.

[Julien Brianceau]

Created attachment 215397 [details]
Fix CPU(ARM_TRADITIONAL) build after r157690 (with more verbose ChangeLog)

[WebKit Commit Bot]

Comment on attachment 215397 [details]
Fix CPU(ARM_TRADITIONAL) build after r157690 (with more verbose ChangeLog)

Clearing flags on attachment: 215397

Committed r158205: <http://trac.webkit.org/changeset/158205>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.