Bug 123104 - Fixing mediastream debug build
Summary: Fixing mediastream debug build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 11:01 PDT by Thiago de Barros Lacerda
Modified: 2013-10-21 12:00 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2013-10-21 11:04 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2013-10-21 11:34 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-10-21 11:01:15 PDT
After https://bugs.webkit.org/show_bug.cgi?id=123075
Comment 1 Thiago de Barros Lacerda 2013-10-21 11:04:54 PDT
Created attachment 214751 [details]
Patch
Comment 2 Andreas Kling 2013-10-21 11:06:12 PDT
Comment on attachment 214751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214751&action=review

> Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47
>      ASSERT(type == eventNames().tonechangeEvent);

If this variable is only used for the assertion, you should change it to an ASSERT_UNUSED.
Comment 3 Thiago de Barros Lacerda 2013-10-21 11:08:30 PDT
(In reply to comment #2)
> (From update of attachment 214751 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214751&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47
> >      ASSERT(type == eventNames().tonechangeEvent);
> 
> If this variable is only used for the assertion, you should change it to an ASSERT_UNUSED.

Fine
Comment 4 Thiago de Barros Lacerda 2013-10-21 11:34:07 PDT
Created attachment 214758 [details]
Patch
Comment 5 WebKit Commit Bot 2013-10-21 12:00:56 PDT
Comment on attachment 214758 [details]
Patch

Clearing flags on attachment: 214758

Committed r157723: <http://trac.webkit.org/changeset/157723>
Comment 6 WebKit Commit Bot 2013-10-21 12:00:59 PDT
All reviewed patches have been landed.  Closing bug.