Bug 123075 - Removing "unused parameter" compiling warnings from WebKit2 and WebCore
Summary: Removing "unused parameter" compiling warnings from WebKit2 and WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-19 19:45 PDT by Thiago de Barros Lacerda
Modified: 2013-10-21 10:45 PDT (History)
19 users (show)

See Also:

Attachments
Patch (15.18 KB, patch)
2013-10-19 19:49 PDT, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
Patch (15.17 KB, patch)
2013-10-20 06:38 PDT, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-10-19 19:45:35 PDT 
Removing general compiling warnings from WebKit2 and WebCore
Comment 1 Thiago de Barros Lacerda 2013-10-19 19:49:01 PDT 
Created attachment 214684 [details]
Patch
Comment 2 Anders Carlsson 2013-10-19 21:39:40 PDT 
Comment on attachment 214684 [details]
Patch

Looks like these are all unused parameter warnings? If so, could you update the title of the bug and ChangeLog?
Comment 3 Thiago de Barros Lacerda 2013-10-20 06:29:18 PDT 
(In reply to comment #2)
> (From update of attachment 214684 [details])
> Looks like these are all unused parameter warnings? If so, could you update the title of the bug and ChangeLog?

Sure :)
Comment 4 Thiago de Barros Lacerda 2013-10-20 06:38:36 PDT 
Created attachment 214698 [details]
Patch
Comment 5 WebKit Commit Bot 2013-10-20 07:14:15 PDT 
Comment on attachment 214698 [details]
Patch

Clearing flags on attachment: 214698

Committed r157700: <http://trac.webkit.org/changeset/157700>
Comment 6 WebKit Commit Bot 2013-10-20 07:14:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Hugo Parente Lima 2013-10-21 10:27:22 PDT 
Comment on attachment 214698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214698&action=review

> Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47
>      ASSERT(type == eventNames().tonechangeEvent);

Remove the type parameter will break the debug build due to the assert using it.
Comment 8 Thiago de Barros Lacerda 2013-10-21 10:45:26 PDT 
(In reply to comment #7)
> (From update of attachment 214698 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214698&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47
> >      ASSERT(type == eventNames().tonechangeEvent);
> 
> Remove the type parameter will break the debug build due to the assert using it.

Sorry, you are right. Didn't pay attention to the debug build because I thought that the build bots would alert me.
Maybe they don't have MediaStream enabled.
Fixing that in other patch now