Bug 123075 – Removing "unused parameter" compiling warnings from WebKit2 and WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Thiago de Barros Lacerda]

Removing general compiling warnings from WebKit2 and WebCore

[Thiago de Barros Lacerda]

Created attachment 214684 [details]
Patch

[Anders Carlsson]

Comment on attachment 214684 [details]
Patch

Looks like these are all unused parameter warnings? If so, could you update the title of the bug and ChangeLog?

[Thiago de Barros Lacerda]

(In reply to comment #2)
> (From update of attachment 214684 [details])
> Looks like these are all unused parameter warnings? If so, could you update the title of the bug and ChangeLog?

Sure :)

[Thiago de Barros Lacerda]

Created attachment 214698 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 214698 [details]
Patch

Clearing flags on attachment: 214698

Committed r157700: <http://trac.webkit.org/changeset/157700>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Hugo Parente Lima]

Comment on attachment 214698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214698&action=review

> Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47
>      ASSERT(type == eventNames().tonechangeEvent);

Remove the type parameter will break the debug build due to the assert using it.

[Thiago de Barros Lacerda]

(In reply to comment #7)
> (From update of attachment 214698 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214698&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47
> >      ASSERT(type == eventNames().tonechangeEvent);
> 
> Remove the type parameter will break the debug build due to the assert using it.

Sorry, you are right. Didn't pay attention to the debug build because I thought that the build bots would alert me.
Maybe they don't have MediaStream enabled.
Fixing that in other patch now