Bug 122974 - Remove saving callFrameRegister to JITStackFrame in JITCompiler::compileFunction()
Summary: Remove saving callFrameRegister to JITStackFrame in JITCompiler::compileFunct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 121756
  Show dependency tree / graph
 
Reported: 2013-10-17 11:04 PDT by Michael Saboff
Modified: 2013-10-17 11:56 PDT (History)
0 users

See Also:

Attachments
Patch (2.23 KB, patch)
2013-10-17 11:32 PDT, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-10-17 11:04:44 PDT 
This is no longer needed as the stack check and arity check are now operations.  
Change is to delete two instances of
    move(stackPointerRegister, GPRInfo::argumentGPR0);
    poke(GPRInfo::callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof(void*));
in Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
Comment 1 Michael Saboff 2013-10-17 11:32:08 PDT 
Created attachment 214475 [details]
Patch
Comment 2 Geoffrey Garen 2013-10-17 11:46:34 PDT 
Comment on attachment 214475 [details]
Patch

r=me
Comment 3 Michael Saboff 2013-10-17 11:56:07 PDT 
Committed r157586: <http://trac.webkit.org/changeset/157586>