Bug 122967 – [GTK] Removing flags for tests fixed in bug 121828

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Javier Fernandez]

Theses tests were flagged as Missing, since expected filed should be re-generated after fixing bug 121828. 

fast/regions/auto-size/autoheight-regions-mark.html [ Missing ]
fast/regions/flows-dependency-dynamic-remove.html [ Missing ]
fast/regions/multiple-directionality-changes-in-variable-width-regions.html [ Missing ]
fast/regions/text-region-split-small-pagination.html [ Missing ]
fast/regions/top-overflow-out-of-second-region.html [ Missing ]

[Javier Fernandez]

Created attachment 214462 [details]
result of "multiple-directionality-changes-in-variable-width-regions" test.

[Javier Fernandez]

Created attachment 214463 [details]
result of "text-region-split-small-pagination" test.

[Javier Fernandez]

Created attachment 214464 [details]
result of "top-overflow-out-of-second-region" test.

[Javier Fernandez]

Created attachment 214465 [details]
Removing tests from Gtk+ TestExpectations

[Manuel Rego Casasnovas]

Comment on attachment 214465 [details]
Removing tests from Gtk+ TestExpectations

View in context: https://bugs.webkit.org/attachment.cgi?id=214465&action=review

> LayoutTests/platform/gtk-wk2/TestExpectations:195
> +

Some of these changes are unrelated to the topic of the bug and the comment in the ChangeLog. Maybe, it'd be a better idea to move the unrelated part into a different patch.

[Javier Fernandez]

Created attachment 214993 [details]
Removing tests from Gtk+ TestExpectations

[Manuel Rego Casasnovas]

Comment on attachment 214993 [details]
Removing tests from Gtk+ TestExpectations

View in context: https://bugs.webkit.org/attachment.cgi?id=214993&action=review

Informal review.

> LayoutTests/ChangeLog:3
> +        Removing flags for tests fixed in bug 121828

I'd add [GTK] here, as the patch only affects to the GTK+ port.

> LayoutTests/ChangeLog:8
> +        * platform/gtk-wk2/TestExpectations:

You're not modifying this file so it shouldn't appear in the ChangeLog.

> LayoutTests/platform/gtk/TestExpectations:47
>  webkit.org/b/121828 fast/repaint/region-painting-via-layout.html [ Missing ]

There're 3 more tests related to bug #121828, why don't remove all of them from TestExpectations file and provide new baselines if required?

[Javier Fernandez]

Created attachment 215038 [details]
Removing tests from Gtk+ TestExpectations

[Javier Fernandez]

(In reply to comment #7)
> (From update of attachment 214993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214993&action=review
> 
> Informal review.
> 
> > LayoutTests/ChangeLog:3
> > +        Removing flags for tests fixed in bug 121828
> 
> I'd add [GTK] here, as the patch only affects to the GTK+ port.

I'll do.

> 
> > LayoutTests/ChangeLog:8
> > +        * platform/gtk-wk2/TestExpectations:
> 
> You're not modifying this file so it shouldn't appear in the ChangeLog.
> 

Yes, I'll change that.

> > LayoutTests/platform/gtk/TestExpectations:47
> >  webkit.org/b/121828 fast/repaint/region-painting-via-layout.html [ Missing ]
> 
> There're 3 more tests related to bug #121828, why don't remove all of them from TestExpectations file and provide new baselines if required?

Those 3 additional tests, supposedly passing because of bug 121828 has been already fixed, haven't got any expected result file, and I'm not confident enough to include the one generated by my build.

I think it would be better to keep them flagged, for the time being.

[WebKit Commit Bot]

Comment on attachment 215038 [details]
Removing tests from Gtk+ TestExpectations

Clearing flags on attachment: 215038

Committed r157921: <http://trac.webkit.org/changeset/157921>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.